Re: [Yaffs] Re: [PATCH] treat OOB as a single chunk of oobavail bytes

From: Vitaly Wool <vwool@ru.mvista.com>
To: Sergey Kubushyn <ksi@koi8.net>
Cc: yuri.golovach@mindspeed.com, manningc2@actrix.gen.nz,
	linux-mtd@lists.infradead.org, yaffs@stoneboat.aleph1.co.uk
Subject: Re: [Yaffs] Re: [PATCH] treat OOB as a single chunk of oobavail bytes
Date: Mon, 30 Jan 2006 11:11:06 +0300	[thread overview]
Message-ID: <43DDCA1A.2050907@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.31ksi3.0601291807000.15886-100000@home-gw.koi8.net>

Hello Sergey,

I'm afraid I haven't got your allusions... Anyway, you might want to 
learn more about main principles of modularity.

Best regards,
   Vitaly

Sergey Kubushyn wrote:

>On Sun, 29 Jan 2006, Vitaly Wool wrote:
>
>Guys, can you explain what is the need for such a change in the first place?
>Another round of confusion? Forcing everybody to upgrade their painfully
>crafted kernels (your CVS version won't apply to e.g. 2.6.12 kernel that was
>the last one before rather major change in ARM architecture, will it?)?
>
>Why don't just fix YAFFS2 itself to make it work with a stock kernel? It's
>easy to do and the appropriate patch is out for quite a long time, tested
>and works for everyone. Patch for YAFFS2 it is, not for kernel.
>
>Occam was a wise man so it does make sence to use his razor... Belly cover
>weared without a need is harmful (C) K.Prutkov ....
>
>  
>
>>Hi Charles,
>>
>>no it's not yet in CVS. I think I'll be able to commit it if we get any
>>positive feedback on this patch (i. e. if it's actually working for
>>anyone else than me :))
>>As for write_oobfree, it looks to be  useful for JFFSx to stop messing
>>with oobinfos in JFFSx code.
>>
>>Best regards,
>>  Vitaly
>>
>>Charles Manning wrote:
>>
>>    
>>
>>>On Friday 27 January 2006 01:51, Vitaly Wool wrote:
>>>
>>>
>>>      
>>>
>>>>Hi Yuri,
>>>>
>>>>well, lemme just summarize what you hafta do in order to make YAFFS2
>>>>work with my patches.
>>>>
>>>>1. Apply the following patch to the mtd code:
>>>>
>>>>        
>>>>
>>http://lists.infradead.org/pipermail/linux-mtd/2005-December/014648.html
>>    
>>
>>>>(yes, it's a single patch!)
>>>>2. Modify the fs/yaffs2/yaffs_mtdif2.c to use
>>>>        
>>>>
>>read_oobfree/write_oobfree
>>    
>>
>>>>where appropriate.
>>>>
>>>>Hope that helps,
>>>>
>>>>  Vitaly
>>>>
>>>>        
>>>>
>>>Hi Vitaly
>>>
>>>Is this in CVS yet? If not, I hope it will be there soon.
>>>
>>>From what I see, this is going to be just what we need.
>>>
>>>YAFFS2 does not need to write_oobfree as a seperate function (it is
>>>always written as a single page write). YAFFS2 only needs
>>>      
>>>
>>read_oobfree.
>>    
>>
>>>However, YAFFS1 could use the write_oobfree function at some future
>>>date if YAFFS1 gets moved to this interface to remove the current
>>>reliance on hanging the ugly ECC parameter stuff through the
>>>      
>>>
>>interface.
>>    
>>
>>>I am pretty busy right now, but will try get the YAFFS2 side sorted
>>>ASAP. If the YAFFS2 stuff is CVSed before the mtd then I'll just
>>>      
>>>
>>point
>>    
>>
>>>people to this patch.
>>>
>>>Thanx!
>>>
>>>Charles
>>>
>>>
>>>
>>>
>>>      
>>>
>>
>>_______________________________________________
>>yaffs mailing list
>>yaffs@stoneboat.aleph1.co.uk
>>http://stoneboat.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs
>>
>>    
>>
>
>---
>******************************************************************
>*  KSI@home    KOI8 Net  < >  The impossible we do immediately.  *
>*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
>******************************************************************
>
>
>  
>