From: Vignesh R <vigneshr@ti.com>
To: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>,
<linux-mtd@lists.infradead.org>, <boris.brezillon@bootlin.com>,
<marek.vasut@gmail.com>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <robh@kernel.org>, <mark.rutland@arm.com>, <shawnguo@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<computersforpeace@gmail.com>, <frieder.schrempf@exceet.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] spi: add support for octal mode data transfer
Date: Thu, 4 Oct 2018 14:52:18 +0530 [thread overview]
Message-ID: <43cff872-0dc5-d3ce-ca35-082faa0e0e7c@ti.com> (raw)
In-Reply-To: <1538642920-3843-1-git-send-email-yogeshnarayan.gaur@nxp.com>
Hi Yogesh,
On Thursday 04 October 2018 02:18 PM, Yogesh Gaur wrote:
> Add support for octal mode IO data transfer.
> Micron flash, mt35xu512aba, supports octal mode data transfer and
> NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
>
> Patch series
> * Add support for octal mode flags and parsing of same in spi driver.
> * Add octal data communication commands required for mt35xu512aba [1] flash.
> * Add support for Read and Write proto for (1-1-8/1-8-8) mode.
> * Add mode bit required for octal mode in nxp-fspi driver [2].
> * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2].
>
> Tested on LX2160ARDB target with nxp-fspi driver, below are
> Read performance number of 1-1-1 and 1-1-8 read protocol.
>
> root@lxxx:~# cat /proc/mtd
> dev: size erasesize name
> mtd0: 04000000 00001000 "spi0.0"
> mtd1: 04000000 00001000 "spi0.1"
> root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read
> Copied 16777216 bytes from address 0x00000000 in flash to 0read
>
> real 0m2.792s
> user 0m0.000s
> sys 0m2.790s
> root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read
> Copied 16777216 bytes from address 0x00000000 in flash to 0read
>
> real 0m0.441s
> user 0m0.000s
> sys 0m0.440s
> root@ls1012ardb:~#
>
> Flash device MTD0 configured in 1-1-1 protocol.
> Flash device MTD1 configured in 1-1-8 protocol.
>
> [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=66317
> [2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=66887
>
> Yogesh Gaur (4):
> spi: add support for octal I/O data transfer
> mtd: spi-nor: add support for octal mode data transfer
> spi: nxp-fspi: add mode flag bit for octal support
> arm64: dts: lx2160a: update fspi node
This is a bit confusing and difficult to follow. I suggest to order
patches such that spi-nor layer changes are at the first, then m25p80
related things, followed by spi-mem (if needed spi) changes and finally
spi-mem controller driver changes.
--
Regards
Vignesh
next prev parent reply other threads:[~2018-10-04 9:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:48 [PATCH 0/4] spi: add support for octal mode data transfer Yogesh Gaur
2018-10-04 8:48 ` [PATCH 1/4] spi: add support for octal I/O " Yogesh Gaur
2018-10-04 9:04 ` Boris Brezillon
2018-10-04 9:14 ` Yogesh Narayan Gaur
2018-10-04 9:19 ` Boris Brezillon
2018-10-04 9:25 ` Yogesh Narayan Gaur
2018-10-04 12:07 ` Yogesh Narayan Gaur
2018-10-04 12:12 ` Boris Brezillon
2018-10-04 8:48 ` [PATCH 2/4] mtd: spi-nor: add support for octal mode " Yogesh Gaur
2018-10-04 9:14 ` Boris Brezillon
2018-10-04 8:48 ` [PATCH 3/4] spi: nxp-fspi: add mode flag bit for octal support Yogesh Gaur
2018-10-04 8:48 ` [PATCH 4/4] arm64: dts: lx2160a: update fspi node Yogesh Gaur
2018-10-04 9:18 ` Boris Brezillon
2018-10-04 9:24 ` Yogesh Narayan Gaur
2018-10-04 9:26 ` Boris Brezillon
2018-10-04 9:27 ` Yogesh Narayan Gaur
2018-10-04 9:22 ` Vignesh R [this message]
2018-10-04 9:28 ` [PATCH 0/4] spi: add support for octal mode data transfer Yogesh Narayan Gaur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43cff872-0dc5-d3ce-ca35-082faa0e0e7c@ti.com \
--to=vigneshr@ti.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@exceet.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox