Re: [PATCH] Fixup in NAND bad block management + fix of misspring .(nand_base.c)

Vitaly Wool
2006-02-10T06:52:32Z

Hi Alexey,

> You wrote
> >> + /* If pattern is given we must use offset from badblock_pattern
> >> structure
> >> + else we should use badblockpos which is filled by default
> >> values */
> >> + if (this->badblock_pattern)
> >> + badblockpos=this->badblock_pattern->offs;
> >> + else
> >> + badblockpos=this->badblockpos;
> >> +
>
> > I'm not sure this is right. If badblock_pattern is set, we shouldn't
> > ever be here.
>
> We definetely get here and badblock_pattern is given for the case of
> ST Nand. This patch should fix bad block marking issues found on ST
> Nand. Why we shouldn't be here if bad block pattern is given?
>
Because if bad block pattern is used, we should use bad block table.
This is how I see it, though I can be wrong.

> Please see patch below. I believe there shouldn't be tab issues.
>
I'm afraid there still are. It's probably due to your mailer converting
tabs to spaces.

Best regards,
Vitaly