Re: [PATCH/RFC] Linux MTD striping middle layer

Artem B. Bityutskiy
2006-03-22T17:08:54Z

On Tue, 2006-03-21 at 15:36 +0300, Belyakov, Alexander wrote:
> Hello,
>
> attached diff file is a patch to be applied on MTD snapshot 20060315
> introducing striping feature for Linux MTD. Despite striping
> is well known feature is was not implemented in MTD for some reason.
> We did it and ready to share with community. Hope, striping will find
> its
> place in Linux MTD.

$ diffstat stripe.diff
b/drivers/mtd/Kconfig | 47
b/drivers/mtd/Makefile | 1
b/drivers/mtd/chips/Kconfig | 7
b/drivers/mtd/chips/Makefile | 2
b/drivers/mtd/chips/cfi_cpt.c | 345 +++
b/drivers/mtd/maps/mphysmap.c | 20
b/drivers/mtd/mtdstripe.c | 3556
+++++++++++++++++++++++++++++++++++
b/include/linux/mtd/cfi_cpt.h | 47
b/include/linux/mtd/stripe.h | 40
drivers/mtd/chips/Makefile | 1
drivers/mtd/chips/cfi_cmdset_0001.c | 109 -
drivers/mtd/chips/cfi_cpt.c | 1
drivers/mtd/maps/mphysmap.c | 1
include/linux/mtd/cfi_cpt.h | 1
include/linux/mtd/stripe.h | 1
15 files changed, 4144 insertions(+), 33 deletions(-), 2
modifications(!)

You definitely have to split your patch on several parts. Your patch has
to only affect drivers/mtd/mtdstripe.c and include/linux/mtd/stripe.h.
If you have to modify other subsystem, send the modification separately,
motivate them and let the corresponding janitor to review them.

--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.