Re: [PATCH/RFC] MTD: Striping layer core

Jörn Engel
2006-03-31T12:21:28Z

On Fri, 31 March 2006 16:11:12 +0400, Artem B. Bityutskiy wrote:
> On Fri, 2006-03-31 at 13:59 +0200, Jörn Engel wrote:
> > Whether the flash can mark things obsolete is a flash feature. At
> > least this is based on a flash feature. So maybe we should rename it
> > to MTD_CAN_FLIP_SINGLE_BITS or similar and then have
>
> This is better then "can mark obsolete". At lease this does not depend
> on application. But I still think that the number of features like is
> unpredictable and large. If the number of bits in mtd->flags is not
> enough, will you introduce mtd->flags1? This is not very generic
> approach.

I believe the number of sane features is not very high. Right now,
jffs2 is de-facto the only thing to worry about. And last time I
checked (two weeks ago), there were not many different decisions based
on flash type.

It was just notable that decisions were based on (type==THIS ||
(type==that && flags==bla) || (type==whatnot). And I'd like to get
rid of such code.

If you send a new filesystem to be merged and that one requires 52
sane new features, you may be right.

Jörn

--
The grand essentials of happiness are: something to do, something to
love, and something to hope for.
-- Allan K. Chalmers