Re: [PATCH/RFC] MTD: Striping layer core

Jörn Engel
2006-03-30T12:12:17Z

On Thu, 30 March 2006 11:57:37 +0400, Belyakov, Alexander wrote:
> diff -uNr a/drivers/mtd/maps/mphysmap.c b/drivers/mtd/maps/mphysmap.c
> --- a/drivers/mtd/maps/mphysmap.c 2006-03-28 12:08:28.000000000
> +0400
> +++ b/drivers/mtd/maps/mphysmap.c 2006-03-28 12:10:48.000000000
> +0400
> @@ -12,6 +12,9 @@
> #ifdef CONFIG_MTD_PARTITIONS
> #include <linux/mtd/partitions.h>
> #endif
> +#ifdef CONFIG_MTD_CMDLINE_STRIPE
> +#include <linux/mtd/stripe.h>
> +#endif

Move the #ifdef into the header.

> static struct map_info mphysmap_static_maps[] = {
> #if CONFIG_MTD_MULTI_PHYSMAP_1_WIDTH
> @@ -155,6 +158,15 @@
> };
> };
> up(&map_mutex);
> +
> +#ifdef CONFIG_MTD_CMDLINE_STRIPE
> +#ifndef MODULE
> + if(mtd_stripe_init()) {
> + printk(KERN_WARNING "MTD stripe initialization from cmdline
> has failed\n");
> + }
> +#endif
> +#endif
> +
> return 0;
> }

o Lindent.
o Dokumentation/CodingStyle
o remove #ifdefs

Your code suffers from a lot of very basic things that make it hard to
review. In its current state, you get a clean NACK from me. Whether
the design makes sense, I didn't even look at. You seem to receive
enough feedback there already.

Jörn

--
You cannot suppose that Moliere ever troubled himself to be original in the
matter of ideas. You cannot suppose that the stories he tells in his plays
have never been told before. They were culled, as you very well know.
-- Andre-Louis Moreau in Scarabouche