Re: [PATCH/RFC] MTD: Striping layer core

Alexander Belyakov
2006-03-31T06:53:11Z

Jörn Engel wrote:
> On Thu, 30 March 2006 11:57:37 +0400, Belyakov, Alexander wrote:
>> diff -uNr a/drivers/mtd/maps/mphysmap.c b/drivers/mtd/maps/mphysmap.c
>> --- a/drivers/mtd/maps/mphysmap.c 2006-03-28 12:08:28.000000000
>> +0400
>> +++ b/drivers/mtd/maps/mphysmap.c 2006-03-28 12:10:48.000000000
>> +0400
>> @@ -12,6 +12,9 @@
>> #ifdef CONFIG_MTD_PARTITIONS
>> #include <linux/mtd/partitions.h>
>> #endif
>> +#ifdef CONFIG_MTD_CMDLINE_STRIPE
>> +#include <linux/mtd/stripe.h>
>> +#endif
>
> Move the #ifdef into the header.

May I ask what is the reason for that (taking into account that
partitions.h is already included here the same way for the same purpose)?

> Your code suffers from a lot of very basic things that make it hard to
> review.

What exactly you wish to see here? Hope I can bring clarifications by
changing code/comments or via this mailing list.

Thanks,
Alexander Belyakov