Re: [PATCH/RFC] MTD: Striping layer core

Jörn Engel
2006-03-31T08:47:20Z

On Fri, 31 March 2006 10:52:59 +0400, Alexander Belyakov wrote:
>
> >Your code suffers from a lot of very basic things that make it hard to
> >review.
>
> What exactly you wish to see here? Hope I can bring clarifications by
> changing code/comments or via this mailing list.

To some degree, I leave it to you to take a look at your code and
improve it. There is little point in me pointing out every detail.
In that case I could just write the code myself.

As a starting point, you should take a close look at
Dokumentation/CodingStyle and will notice that your code has a rather
different style. Worse, your style is not even consistent within
itself. People will be more inclined to take a closer look if the
code looks similar to what they would expect elsewhere.

Then there's the general rule to make code simple to read. #ifdef is
a concept that makes code complicated. Avoiding it where possible is
a good idea. Having the #ifdef once in a header is better than having
it once in each source file including the header. Having pretty much
anything once is better than having it in many places.

When you're done with this, please come back. I'll take a closer look
then.

Jörn

--
Public Domain - Free as in Beer
General Public - Free as in Speech
BSD License - Free as in Enterprise
Shared Source - Free as in "Work will make you..."