Re: [PATCH/RFC] MTD: Striping layer core

Artem B. Bityutskiy
2006-03-31T07:58:11Z

Alexander Belyakov wrote:
>>> @@ -12,6 +12,9 @@
>>> #ifdef CONFIG_MTD_PARTITIONS
>>> #include <linux/mtd/partitions.h>
>>> #endif
>>> +#ifdef CONFIG_MTD_CMDLINE_STRIPE
>>> +#include <linux/mtd/stripe.h>
>>> +#endif
>>
>> Move the #ifdef into the header.
>
> May I ask what is the reason for that (taking into account that
> partitions.h is already included here the same way for the same purpose)?

Just in general, the

#ifdef EPRST
#include <elki-palki.h>
#endif

is not very nice. It is nicer to add the #ifdef protection in the header
itself. This is not a major problem, but it is just nicer and Linux
people like this. Just incapsulate all the protection in the header
itself. Don't spread the protection over many .c files which may
potentially want to include your header.

--
Best Regards,
Artem B. Bityutskiy,
St.-Petersburg, Russia.