checking write_cached_data return status inside _release and _flush?

checking write_cached_data return status inside _release and _flush?

[Massimiliano Galanti]

hi!

i experienced some corruption of data on flash memories i am using, and
discovered that this is related to these functions in mtdblock.c:

	static int mtdblock_release(struct mtd_blktrans_dev *mbd)
	static int mtdblock_flush(struct mtd_blktrans_dev *dev)

not checking the return value of the function:

         write_cached_data(mtdblk)

i fixed that by checking the return value inside a while cycle but is 
there any particular reason the original code is written that way?

Thank you.

-- 
Massimiliano Galanti

-IM-----------------------
MSN:  viperzed@hotmail.com
Yahoo: massimilianogalanti
ICQ:             227544335
Skype: massimilianogalanti
--------------------------

Re: checking write_cached_data return status inside _release and _flush?

[Jörn Engel]

On Fri, 7 April 2006 20:03:13 +0200, Massimiliano Galanti wrote:
> 
> i experienced some corruption of data on flash memories i am using, and
> discovered that this is related to these functions in mtdblock.c:
> 
> 	static int mtdblock_release(struct mtd_blktrans_dev *mbd)
> 	static int mtdblock_flush(struct mtd_blktrans_dev *dev)
> 
> not checking the return value of the function:
> 
>         write_cached_data(mtdblk)
> 
> i fixed that by checking the return value inside a while cycle but is 
> there any particular reason the original code is written that way?

Sounds like a plain bug.  Can you send a patch?

Jörn

-- 
If you're willing to restrict the flexibility of your approach,
you can almost always do something better.
-- John Carmack

Re: checking write_cached_data return status inside _release and _flush?

[Jörn Engel]

On Mon, 10 April 2006 13:46:08 +0200, massiblue@libero.it wrote:
> 
> i'll fix it properly (finite number of retries, error handling etc...) against 2.6.16.2 and send you the patch, ok?

Great!

Jörn

-- 
"Error protection by error detection and correction."
-- from a university class