Re: [PATCH] MTD: mtdconcat NAND/Sibley support

[Alexander Belyakov <alexander.belyakov@intel.com>]

Jorn Engel wrote:
>
> concat_writev() is far too complicated.  I have a patch somewhere that
> adds a generic writev() function to every device.  Once that is in,
> your patch should get a respin and be much simpler.
>

Having generic writev() still requires concat_writev() to split the data 
into several parts (in general case by number of subdevices). So I do 
not see how concat_writev() could become simpler.

In my patch you split data from downcoming vector into several  _equal_  
page-sized chunks and write them by calling generic write().

In case you think about one have to create  _several_vectors_  of  
_unknown_  size and pass them to the generic writev() which in turn will 
anyway split these new vectors into equal page-sized chunks.

And I really doubt there is a way to simplify concat_block_isbad() and 
concat_block_markbad() functions from the patch.

> I didn't closely look at the rest of it but suspect similar things.
>

Why I'm not surprised here? :)

Patch have nothing complex and have completely nothing new. Just fixes 
some broken stuff.

Is it better to leave concatenation layer without any changes and only 
compatible with NOR devices, despite mtdconcat.c file comments claim 
that it does support NAND?

Alexander

-------
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue