Re: [PATCH] MTD: mtdconcat NAND/Sibley support

[Alexander Belyakov <alexander.belyakov@intel.com>]

Nicolas Pitre wrote:
>
> That won't work with Sibley.
>

It does work for Sibley. I've checked it for both NAND and Sibley before 
posting.

> Sibley flash must write everything all at once with
> a single writev call.
>

Not sure what did you  mean by that. But I should say that 
concat_writev() function does writes by page-sized chunks even if one 
vector entry has size less than one page. Function just "glues" it with 
the next vector entry (or its part) if any. So there are no writes with 
size less than pagesize, except first and last pages if we have 
unaligned data in downcoming vector.


As for too "complex" patch implementation. I'll take a look what can be 
done with usage of writev() and writev_ecc() of underlying devices. 
Thank you for advice. But as I said this change is just design matter 
and will not benefit much, because underlying device writev() function 
have to do the pagesize chunks splitting anyway.

Alexander

-------
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue