Re: [PATCH] XATTR support on JFFS2 (version. 5)

David Woodhouse
2006-05-11T23:31:27Z

On Fri, 2006-05-12 at 08:16 +0900, KaiGai Kohei wrote:
>
> The pre-patched implementation ignores this error code and
> doesn't care. Theredore, total process of FS-mounting failed.
> This patch fixes this problem, When we found such a obsolete
> node, it will be dealt as a DIRTY_SPACE() and FS-mounting
> will be continued.
>
> It works correctly, and I belive this solution is right.

It does look correct to me. The patch seems to highlight some
inconsistency of tabs vs. spaces in the indenting though.

When committing to the a git tree, please remember that if I pull from
it and then Linux pulls from it, the 'subject' of your commit should be
meaningful in that context. So it should mention 'JFFS2' at the very
least.

That's probably not quite so important for your jffs2-xattr tree, since
I think I'll probably import that as a _patch_ when we're ready, rather
than just pulling the whole thing. But in general, it's a useful thing
to remember for people committing to git trees and expecting me to pull
from them.

--
dwmw2