Re: [PATCH] XATTR support on JFFS2 (version. 5)

Artem B. Bityutskiy
2006-05-10T11:23:10Z

On Wed, 2006-05-10 at 12:06 +0100, David Woodhouse wrote:
> It's not even 'minor'. It's total bullshit. If you can't look at the
> function name "delete_XATTR_REF" and work out what 'ref' is in that
> context, then you really shouldn't be trying to read the code. Life is
> hard; let's go shopping.
It's not bullshit. The name of function has nothing to do here - there
are many places like that (1), the function name does not have to
correlate (2).

> I got annoyed with you when you started on stuff like this in JFFS2
> code. Don't start on the XATTR code too.
I remember - you prevented me from many clean-ups and tidy-ups.

> I do see your point to a _certain_ extent, but let's concentrate on
> things that actually matter instead, OK?
I also see your point. Sorry, but I do not agree with this strategy.
Many things which "don't matter" may start mattering sooner or later.

Thanks.