Re: [PATCH] XATTR support on JFFS2 (version. 5)

KaiGai Kohei
2006-05-07T00:23:20Z

Hello,

David Woodhouse wrote:
> I don't like that very much either, to be honest. How about getting rid
> of jffs2_garbage_collect_xattr() altogether, and using this in gc.c
> instead...
>
> #ifdef CONFIG_JFFS2_FS_XATTR
> /* When 'ic' refers xattr_datum/xattr_ref, this node is GCed as xattr.
> We can decide whether this node is inode or xattr by ic->class. */
> if (ic->class == RAWNODE_CLASS_XATTR_DATUM ||
> ic->class == RAWNODE_CLASS_XATTR_REF) {
> spin_unlock(&c->erase_completion_lock);
> /* XXXXXX? */
> down_write(&c->xattr_sem);
> if (ic->class == RAWNODE_CLASS_XATTR_DATUM)
> ret = jffs2_garbage_collect_xattr_datum(c, (void *)ic);
> else
> ret = jffs2_garbage_collect_xattr_ref(c, (void *)ic);
> up_write(&c->xattr_sem);
> goto release_sem;
> }
> #endif

OK, I'll fix according to your suggestion.
Only one point, I think xattr_sem should be modified in xattr.c for readability.

>>I haven't known much about detailed git operations yet. But I'm already
>>doing basical operations such as pull/push/... in my local environment.
>>Maybe, here is not significant problem. I'm willing to manage jffs2-xattr-2.6.git
>>tree. Is it necessary to send you my ssh public key, isn't it?
>
>
> Yes, please. I'll add an account for you.

I'll send it to you directly.

Thanks,
--
KaiGai Kohei <kaigai@ak.jp.nec.com>