Re: [PATCH] XATTR support on JFFS2 (version. 5)

KaiGai Kohei
2006-05-12T15:21:17Z

Hi, Thanks for yout comments.

> It does look correct to me. The patch seems to highlight some
> inconsistency of tabs vs. spaces in the indenting though.

Sorry, it's translated by terminal emulator automatically.
The patch keeps consistency of tabs in the indenting.

> When committing to the a git tree, please remember that if I pull from
> it and then Linux pulls from it, the 'subject' of your commit should be
> meaningful in that context. So it should mention 'JFFS2' at the very
> least.

OK, I'll pay attention to attach 'JFFS2' to the subject.
But nine of previous patches which have been already commited did not
attach such a keyword. Is it necessary to update the subject of them ?
(But I don't know how to operate for this. Hmm...)

Thanks,

> That's probably not quite so important for your jffs2-xattr tree, since
> I think I'll probably import that as a _patch_ when we're ready, rather
> than just pulling the whole thing. But in general, it's a useful thing
> to remember for people committing to git trees and expecting me to pull
> from them.
--
KaiGai Kohei <kaigai@kaigai.gr.jp>