Re: [PATCH] XATTR support on JFFS2 (version. 5)

David Woodhouse
2006-05-08T12:49:27Z

On Mon, 2006-05-08 at 11:03 +0900, KaiGai Kohei wrote:
> [Current TODO list]
> * Fix the declaration of jffs2_acl_header and so on by using 'struct'
> instead of 'typedef' in kernel space.
> - Fix the declaration of jffs2_acl_header and so on by using 'struct'
> instead of 'typedef' in user space header.
> * Add documentation about xattr_sem into README.Locking.
> * Call jffs2_garbage_collect_xattr_datum/ref() from gc.c directly
> instead of jffs2_garbage_collect_xattr()
> - Use unidirection list beween inode_chache and xattr_ref, instead of
> list_head.
> - Add '#include <linux/list.h>' into xattr.h.
> - Unify each file header part with any jffs2 files.
> - Remove a senseless comment. ("/* forward refence */")
> - Remove unneccesary pointer casts.
> - Remove unneccesary '#ifdef __KERNEL__' on acl.h
>
> *: It has already prepared, but I've not publicated yet.
> -: It has not prepated yet. I should work from now.

That's an excellent summary; thanks. It does serve to show that we've
mostly picked on cosmetic details so far though :)

If you have patches committed into a git tree, you should be able to
just 'git-push ssh://git.infradead.org/home/git/jffs2-xattr-2.6.git' to
make it available.

--
dwmw2