public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: KaiGai Kohei <kaigai@kaigai.gr.jp>
To: David Woodhouse <dwmw2@infradead.org>
Cc: jmorris@redhat.com, "KaiGai Kohei" <kaigai@ak.jp.nec.com>,
	russell@coker.com.au, linux-mtd@lists.infradead.org,
	lorenzo@gnu.org, sds@tycho.nsa.gov,
	"Jörn Engel" <joern@wohnheim.fh-wedel.de>
Subject: Re: [PATCH] XATTR support on JFFS2 (version. 5)
Date: Sat, 13 May 2006 00:20:17 +0900	[thread overview]
Message-ID: <4464A7B1.4070605@kaigai.gr.jp> (raw)
In-Reply-To: <1147390288.12030.16.camel@shinybook.infradead.org>

Hi, Thanks for yout comments.

> It does look correct to me. The patch seems to highlight some
> inconsistency of tabs vs. spaces in the indenting though.

Sorry, it's translated by terminal emulator automatically.
The patch keeps consistency of tabs in the indenting.

> When committing to the a git tree, please remember that if I pull from
> it and then Linux pulls from it, the 'subject' of your commit should be
> meaningful in that context. So it should mention 'JFFS2' at the very
> least.

OK, I'll pay attention to attach 'JFFS2' to the subject.
But nine of previous patches which have been already commited did not
attach such a keyword. Is it necessary to update the subject of them ?
(But I don't know how to operate for this. Hmm...)

Thanks,

> That's probably not quite so important for your jffs2-xattr tree, since
> I think I'll probably import that as a _patch_ when we're ready, rather
> than just pulling the whole thing. But in general, it's a useful thing
> to remember for people committing to git trees and expecting me to pull
> from them.
-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>

  reply	other threads:[~2006-05-12 15:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-06  6:51 [PATCH] XATTR support on JFFS2 (version. 5) KaiGai Kohei
2006-05-06 12:07 ` David Woodhouse
2006-05-06 12:38   ` David Woodhouse
2006-05-06 16:47     ` KaiGai Kohei
2006-05-06 17:53       ` David Woodhouse
2006-05-07  0:22         ` KaiGai Kohei
2006-05-07  0:29           ` David Woodhouse
2006-05-07 10:19         ` Artem B. Bityutskiy
2006-05-07 13:25       ` Artem B. Bityutskiy
2006-05-07 13:29         ` David Woodhouse
2006-05-07 12:46 ` Artem B. Bityutskiy
2006-05-07 13:12   ` Artem B. Bityutskiy
2006-05-07 13:18   ` David Woodhouse
2006-05-08  1:01     ` KaiGai Kohei
2006-05-07 17:16 ` Jörn Engel
2006-05-08  2:03   ` KaiGai Kohei
2006-05-08 12:49     ` David Woodhouse
2006-05-09 16:10       ` KaiGai Kohei
2006-05-11 23:16         ` KaiGai Kohei
2006-05-11 23:31           ` David Woodhouse
2006-05-12 15:20             ` KaiGai Kohei [this message]
2006-05-12 15:32               ` Jörn Engel
2006-05-12 15:38               ` David Woodhouse
2006-05-13  6:37                 ` KaiGai Kohei
2006-05-13 10:46                   ` David Woodhouse
2006-05-10 13:28       ` Jörn Engel
2006-05-10 10:03 ` Artem B. Bityutskiy
2006-05-10 11:06   ` David Woodhouse
2006-05-10 11:22     ` Artem B. Bityutskiy
2006-05-10 12:03     ` KaiGai Kohei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4464A7B1.4070605@kaigai.gr.jp \
    --to=kaigai@kaigai.gr.jp \
    --cc=dwmw2@infradead.org \
    --cc=jmorris@redhat.com \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=kaigai@ak.jp.nec.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lorenzo@gnu.org \
    --cc=russell@coker.com.au \
    --cc=sds@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox