Re: [PATCH] AT91RM9200 NAND support

Andrew Victor
2006-06-20T07:22:27Z

hi Thomas,

> As I pointed out in my previous mail, the driver needs to be updated to
> work with the latest changes in the nand driver.

I didn't see that message - haven't been following the MTD mailing list
lately.

> > +/*
> > + * Hardware specific access to control-lines
> > + */
> > +static void at91_nand_hwcontrol(struct mtd_info *mtd, int cmd)
>
> This function needs to be adjusted.

Some hints of how it should be adjusted would be useful.
(I don't actually have NAND hardware to test it with).

> If you error out after a sucessful nand_scan() - i.e. chip was detected
> - you have to call nand_release(). nand_scan() allocates memory which
> gets freed inside nand_release()

OK, will add calls to nand_release().

Regards,
Andrew Victor