Re: [PATCH] CM-x2xx NAND flash support

[Mike Rapoport <mike@compulab.co.il>]

Thomas Gleixner wrote:

>On Thu, 2006-07-06 at 14:48 +0200, Mike Rapoport wrote:
>  
>
>>This patch provides MTD support for NAND flash devices on CM-x2xx modules.
>>
>>Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>>    
>>
>
>  
>
>  
>
>>+#define DRAIN_WB() \
>>+       do { \
>>+               unsigned char dummy; \
>>+               asm volatile ("mcr p15, 0, r0, c7, c10, 4":::"r0"); \
>>+               dummy=*((unsigned char*)UNCACHED_ADDR); \
>>+       } while(0);
>>    
>>
>
>stray semicolon ----^
>
>I bet xscale has this functionality somewhere as a macro / inline already
>  
>
I found none. Even md() on xscale will not drain write buffer.

>  
>
>>+       unsigned int nandaddr = (unsigned int)this->IO_ADDR_W;
>>    
>>
>
>what the hell is this type cast for ?
>
>	void __iomem *nandaddr = 
>  
>
you can't do |= and &= with void __iomem*

>Can you please combine both drivers into one and make it a platform
>device. There is no need to keep lots of duplicate functionality around.
>
>  
>
I'm dropping cm-x255 support (management decision) so there's only one 
platform that can use this driver. What's the point then?

>	tglx
>
>
>
>______________________________________________________
>Linux MTD discussion mailing list
>http://lists.infradead.org/mailman/listinfo/linux-mtd/
>  
>

-- 
Sincerely yours,
Mike Rapoport