public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Vitaly Wool <vwool@ru.mvista.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux mtd <linux-mtd@lists.infradead.org>,
	Ricard Wanderlof <ricard.wanderlof@axis.com>
Subject: Re: [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't	work when flash-based bbt not enabled (fwd)
Date: Tue, 24 Oct 2006 13:35:40 +0400	[thread overview]
Message-ID: <453DDE6C.2070304@ru.mvista.com> (raw)
In-Reply-To: <1161597141.19446.276.camel@pmac.infradead.org>

David Woodhouse wrote:
> On Mon, 2006-10-23 at 09:33 +0200, Ricard Wanderlof wrote:
>   
>> (As note, it seems to be that logically, it shouldn't be necessary to set 
>> both length variables, as one appears to be for the main buffer, and 
>> one for the oob buffer, but this is how it is done in several places, 
>> including the code for the mtd character device MEMWRITEOOB and MEMREADOOB
>> ioctls. I'm not sure if this is a temporary solution during some rework of 
>> the mtd infrastructure, or whether there is a deeper thought here.)
>>     
>
> Hm. That seems wrong to me. If we don't want to read or write the main
> area, we should set ops.len to zero. And if that doesn't work, it should
> probably be fixed.
>
> I'd rather see a patch which fixes that.
>
>   
We discussed that w/ tglx some time ago and we couldn't find a 5 minute 
solution :)

Vitaly

  parent reply	other threads:[~2006-10-24  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23  7:33 [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled (fwd) Ricard Wanderlof
2006-10-23  9:52 ` David Woodhouse
2006-10-23 10:46   ` [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled Ricard Wanderlof
2006-10-24  9:35   ` Vitaly Wool [this message]
2006-10-26  8:52     ` Ricard Wanderlof
2006-10-26  8:55       ` Vitaly Wool
2006-10-26  9:06         ` Ricard Wanderlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453DDE6C.2070304@ru.mvista.com \
    --to=vwool@ru.mvista.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=ricard.wanderlof@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox