From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [85.21.88.2] (helo=mail.dev.rtsoft.ru) by canuck.infradead.org with smtp (Exim 4.62 #1 (Red Hat Linux)) id 1GcIhE-0007Xw-B4 for linux-mtd@lists.infradead.org; Tue, 24 Oct 2006 05:35:52 -0400 Message-ID: <453DDE6C.2070304@ru.mvista.com> Date: Tue, 24 Oct 2006 13:35:40 +0400 From: Vitaly Wool MIME-Version: 1.0 To: David Woodhouse Subject: Re: [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled (fwd) References: <1161597141.19446.276.camel@pmac.infradead.org> In-Reply-To: <1161597141.19446.276.camel@pmac.infradead.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux mtd , Ricard Wanderlof List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , David Woodhouse wrote: > On Mon, 2006-10-23 at 09:33 +0200, Ricard Wanderlof wrote: > >> (As note, it seems to be that logically, it shouldn't be necessary to set >> both length variables, as one appears to be for the main buffer, and >> one for the oob buffer, but this is how it is done in several places, >> including the code for the mtd character device MEMWRITEOOB and MEMREADOOB >> ioctls. I'm not sure if this is a temporary solution during some rework of >> the mtd infrastructure, or whether there is a deeper thought here.) >> > > Hm. That seems wrong to me. If we don't want to read or write the main > area, we should set ops.len to zero. And if that doesn't work, it should > probably be fixed. > > I'd rather see a patch which fixes that. > > We discussed that w/ tglx some time ago and we couldn't find a 5 minute solution :) Vitaly