From: Vitaly Wool <vwool@ru.mvista.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Linux mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled
Date: Thu, 26 Oct 2006 12:55:17 +0400 [thread overview]
Message-ID: <454077F5.2030905@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0610250851290.25906@lnxricardw.se.axis.com>
Ricard Wanderlof wrote:
> On Tue, 24 Oct 2006, Vitaly Wool wrote:
>
>
>>> Hm. That seems wrong to me. If we don't want to read or write the main
>>> area, we should set ops.len to zero. And if that doesn't work, it should
>>> probably be fixed.
>>>
>>> I'd rather see a patch which fixes that.
>>>
>>>
>>>
>> We discussed that w/ tglx some time ago and we couldn't find a 5 minute
>> solution :)
>>
>
> Was there a discussion on the mtd list? I scanned the archives back to
> April and couldn't find anything.
>
No, we did chat in #mtd channel.
Anyway, here's what I think of that. It looks like the idea was to use
ops.len in order to read more than ooblen bytes, i. e. more than one OOB
area basically, and preserve ooblen to signal how many bytes there is in
one oob. However, that seems misleading/redundant since you can always
figure out how many bytes there are in oob, so it looks like making that
all work w/ ooblen is better.
Does that make sense?
I'm going to work on that as soon as load permits...
Vitaly
next prev parent reply other threads:[~2006-10-26 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 7:33 [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled (fwd) Ricard Wanderlof
2006-10-23 9:52 ` David Woodhouse
2006-10-23 10:46 ` [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled Ricard Wanderlof
2006-10-24 9:35 ` [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled (fwd) Vitaly Wool
2006-10-26 8:52 ` [PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled Ricard Wanderlof
2006-10-26 8:55 ` Vitaly Wool [this message]
2006-10-26 9:06 ` Ricard Wanderlof
-- strict thread matches above, loose matches on Subject: below --
2006-10-20 15:36 Ricard Wanderlof
2006-10-20 15:51 ` Artem Bityutskiy
2006-10-20 19:00 ` Ricard Wanderlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454077F5.2030905@ru.mvista.com \
--to=vwool@ru.mvista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox