From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E0FC00144 for ; Fri, 29 Jul 2022 07:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hrGre6qXmD35hss69Y3aizT5lqVS2wlVfGaaiMlSVWM=; b=j7EnmnNOlLj9U2 Aoou262VDZiDmp0GuINsvrXaUmsL1hEbe/T/MDGrJgDG1w+uMw5yBRlOoajfel3zJyOrPIJHspwcu k52ONrzztGoUq5pB4MmVMj08E9Jtxut0w4BGzlaX96KmVjp3UrWu3rXHHgFmyBbuuk/EMwGYyDips HDpjX5hKH1cPdLO6jkwTT5RY5MjKUF+osHp/SWuJkAMu8FasbXoqryNPIj7YnJ0HI5yFQrwA4CZTD 2ojp23PISOCfWdr8YR0TtBZW3AbNJFIEeeh2Oj8aIHYtrNbWXK0S2mOrkSf//9es2km/NuWmjEKQA JXD7yTtXrUTr1bkch55A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKXe-002eqz-Ea; Fri, 29 Jul 2022 07:36:14 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKXX-002eoC-UL for linux-mtd@lists.infradead.org; Fri, 29 Jul 2022 07:36:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1659080167; x=1690616167; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5dM2JmhNi/9EYWYf5QyLiy2WVObUH2+nWX5kp8nfhBQ=; b=i8Kz1j3pJe0gMjMFi2yQRuO4NImomKh5XsFSlkzkyuDiaboTawWvQDKl qzHv5Nt0oCMContJpsxP02wPVl0gEVoyQeoPHBiEtyNvdyOjaqkswurLk plqukMeqxvEiYsUjggnWX+S2B3D66BSkQp5dChOJFsM6R9/vlGayxWMTM HzFZ/aVy0pcgaJyxCfR2WI9gFmQdeWiZRcPv0D+A5PUc4ipZCh1vnvO3w jn6SCV3xhMyo7BkkL5/BpGiXwkQIXgD7M8ko6E9ONUO/3ZffpSCsX2Sdn 3kBP/rbKCwrnN+VZVsfv7L2P4m+ijthuuG89iSc/HaZeUpKSObX+fyhFo g==; X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="106662204" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 29 Jul 2022 00:36:06 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 00:36:06 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 00:36:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MgsbjDk0GVeSXrCD/ZYiSB4xUu/aqI1mRX14x6CPefqXzxzwQYSgTXfn6VTdGzzMIUbn2aRePmyNCX+cYRUuB/F5Poud8rZwgcCl0m3/ejyEtW6mLhBezdeNczKX1RRRHu9EIURdNXscKlJmEf65YXYHoJd9e5JLNKX/dmdw91e+/ZznxrNHAl0Usug+r9cQ6uI7tauHMAxAlTSwnmbQeF5Ut5zDufJgQSwLmNx6M33CN6HVox+YQo7BgS+pY/HGIkAWNekmPZ3wuRrANJgEilJFfL0oX3szfyHPyGA/ObHv+EknFwlkApQ1g40iiAnQpdI/9iDaxv6L8m4iaPgeGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dM2JmhNi/9EYWYf5QyLiy2WVObUH2+nWX5kp8nfhBQ=; b=G0YSjKF+LyCs4fTlIAjUDiPF3A5UiQH8WNbIxi0dTZbwpVlzTuA3ZKjzsEfHy1biPjVuFEOVA90ZRGgR9gaJCH0Okgkecf9wPNNbm4xhq7bFvfMmonDScK2Bofm4AUXrbalr0hsP33Pmhjv5gB0wstN5450TAjqH+mCkWP4+a65L94bw1n9d1nplORBcvE3NLrJwyZpPSRre4HRgW1kIZ2Qoliy4ZFagpjFcyOdwxTuRIPvikefU0fDYbt8184yWJeeU/9ykEE7IxwgggEvvqj2Nrh9yNU1qboMqqN3lr2s/rJuap5Dm4mdtjYt0CKWB+G/bZocPeg2J28cccnwUwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dM2JmhNi/9EYWYf5QyLiy2WVObUH2+nWX5kp8nfhBQ=; b=GtwXhcVCYH6sdr4SyyotLuuN8gCu4OLzpb9Dnj+dBUZzbPQOb9MetxvRphAzr6ABft05W+YxpI0Ulj8YJvNCUC+zHj8XHZtgaZPL3ZWR8CWdn8n2v0zCga3QDFiu5bMxdOdOO1/se0x9moZKycf7NKVaRB86hiy56qNGVbgsXdA= Received: from DM4PR11MB6479.namprd11.prod.outlook.com (2603:10b6:8:8c::19) by BL3PR11MB6484.namprd11.prod.outlook.com (2603:10b6:208:3bf::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 29 Jul 2022 07:35:56 +0000 Received: from DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::7549:c58c:5e93:7c35]) by DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::7549:c58c:5e93:7c35%5]) with mapi id 15.20.5458.023; Fri, 29 Jul 2022 07:35:55 +0000 From: To: CC: , , , , , , , , , , , Subject: Re: [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags Thread-Topic: [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags Thread-Index: AQHYmsgjen1JGDoDVkiRJKdzpaguzQ== Date: Fri, 29 Jul 2022 07:35:55 +0000 Message-ID: <454aadfb-2c84-5950-3144-97d65e321575@microchip.com> References: <20220712163823.428126-1-sudip.mukherjee@sifive.com> <20220712163823.428126-3-sudip.mukherjee@sifive.com> <3a9877d0-3cc5-6452-764b-d07b38c72b00@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae7b3edf-a9b2-43b8-37ba-08da7134f8e2 x-ms-traffictypediagnostic: BL3PR11MB6484:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /JoFWuQgNCnSClUuN6Tq500hZ+atIQa9w9ZNrV0ofFd7/1bfYvDBQNKscBrMV25QUU2sP+EjnoLBE3QLVVUa3dqk38QGYfx9y+QM7KGy4P9iTJhfXwE20QkoQs9/0g7FZLeYxZLaTC64lonLpuNw4SlWmZSNjJfGLZHvis4pWHDtZSDHjTNdBEWUnMy1EfL4+hJ0e5+9BpoY5Fqj7U2BH9b7oj+IUpsf3o6MwloMgJ92UdZKy8sEYoGOqpjYnU9qCyw8AYO4DdydkkFds23Gsw8NgA6e2ah0GMIu1mUlhWWDW9Z0QWYH4D1IqOOXZpOWzHWowEy73VxaA8jF35QIqWNHuAlpbpGGej1zwHzhfNLJ63vU6QjvjszspE1YHrGCjXc47yok8DG26WXUUNkfY9iRb3xlfvLwqgsGliF84q7/yCJg3KY0RXwhp5ayLYrn5SExCCZ83/T9clBOxhWVCwKvyqunOlFj5rtG8iW7oJsC6lEK4pV/1OSA1wO+hWUlwagxQU9xsXQnbpl1LrKmF9FRwuWkFFdYialqUjra9Mry7vFlDbQucyNlR6XPHQW4+CahA8mL0AhY/zq4n9sNhye4XLU6VSHz0am+yGK0PTb2QkX3qC8z7N4xJR0f2AzVmROmWDps0U07R9AfjLf2WoXbF/XA9jnuQicFeRo8T/FtvCD3bj7a7ifZyCzvkmhbCQ/Ho4mdqPvgdDh/cTwdrsWCB+3lmQE8NWewKz+rIcnF/QBrDpeKpV79wICWax/T1G9mBgWIUmyznxNVoZf0QELmByR5nak61h9rdSkKXpmBW1I4Tl2jBUgnKaIlWFQ1NvSB8zlLr+w4vAdDnAa08ROadvwNGNMxTLy4jXIiQs0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6479.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(39860400002)(366004)(346002)(36756003)(6512007)(6486002)(5660300002)(31686004)(26005)(7416002)(66946007)(966005)(478600001)(91956017)(41300700001)(2906002)(31696002)(8936002)(38100700002)(54906003)(316002)(66446008)(4326008)(71200400001)(6916009)(8676002)(64756008)(122000001)(86362001)(66556008)(53546011)(6506007)(38070700005)(76116006)(66476007)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WHJqN1BmbFNSUkZHbldvbHBCTjhIRTFqNUV6VXlRQVZEcEM1WmRhckdIbFpY?= =?utf-8?B?bG5vVkxMUjk2bEJ6aEFZRGYraXM4L2pwM0xEM0tPanFOWFgyVlpEajZFcXdW?= =?utf-8?B?MC8wVVNTNHFseEhjWnh4V1M1L2VnWHZZemVlVkpITEZ0QlhYVjVCUDJQaVR0?= =?utf-8?B?UnEwVFM2VUVBc3o1UFZoWm91V0J3aUErNUtwVG9nWDc4V1h6amRqNzFVczJ2?= =?utf-8?B?QUptK1pWMld1WWNxRnJBVk53cS93RWNuRUFBblkzUnRkeHVaNk1UN05mQmFa?= =?utf-8?B?NS9zSWRNWjRJUEFwdWRGVUF3ZC9VcDVzMVVwUEM0dktZVUY0SUd3NTloZEpH?= =?utf-8?B?TlRDS3VJM0UyVmhIT0IzbnB3eHFVVksxYXlwRjl6R0p5U3AraC92anRNbHVz?= =?utf-8?B?QjJqZzBhSjVuYSsrQUZRT1VsOHFkYzg3RjJIZXNyR3ZJeTBVNldtS0Rkd1U4?= =?utf-8?B?L2F4UXlKeDMrTzVIeUQ2eUpYeXB3K2FndGFwNHEycUE2TjcxOWVXTFVyd2dj?= =?utf-8?B?L3VkaklMWGRhMXREazFteHFJdmVMaitMdHpQS2RXemlhSXRTbldQVVB3WU1h?= =?utf-8?B?UXVub3NGVENXYnN0aGhXU2U1bkxNbXNJUFJtazlQUlJrdE5NblkyTVBWR2xT?= =?utf-8?B?NGo4MW4xZC9uVEdzOUhkQ0k3aTZIU2srL0Q5Q09pRCtsYXlLMGp5ZFordm5R?= =?utf-8?B?RU56aXZHdllNRkdGSGdHOTJMVmVNUUVacnFpVWp2SUplV3B6Vkd3QWVHOFR5?= =?utf-8?B?MzB3N0NOQWEzL0E5UTdpd096OWJhVjYwOHdid3YvSVc5Qkl2NUFKTDhBTDB2?= =?utf-8?B?aFh1ZUdsSy9KbjhXTWV6MUIzRDJOa0xIMmNGOHF6V1hLVUUrQmU4b21BQmhm?= =?utf-8?B?S3RyVUg0eVpLV25SdWRXZjJXcmN1WnBSYzh0WDJrb0dGc2FmT0d3NHdFcko4?= =?utf-8?B?aXcxelRneG9yYWE4SktWNkNvWkY0b3JpZTRpak90cnkvKzRiSCtaajBZaDVn?= =?utf-8?B?ZjBQb2kzOFpiS1hPMDVNMm1MWVJScXhhclRIbCt3ZXQxdnhYOE9Fc2dtNDNC?= =?utf-8?B?MW9yRTdsc3BHQ3o0SENVLzJPd1NHZmFXM3htNTFKZHYrbWRIVXlMYnFCMGgy?= =?utf-8?B?L3lMcllRRW5hbnl1RjBGc3o0TXprTnlhZ3hFSmExR3V2S1NTVWFLb05EMjBB?= =?utf-8?B?ckZHN0pQY1htN2hsQmc4K3BQK2hpUXYvOVMxUERvZG8vMFdoMXphdXRCdExW?= =?utf-8?B?b1JKYzVETGk5S2JMOWtzQkZHTi8yZ3ZveTRTOU53WkQ0d2xlRkRVQkljeXdz?= =?utf-8?B?ai9yMnNuM0dHVHFaMXNVOEtDMXM4VUYzZnJmQWpWL2JJS3FQeEhOV0ZtQXds?= =?utf-8?B?ODN6QkVTa2E4Sm9ZWk5KTUVHNkdKOWp6dHBWckMvNFVuY0NmSGFiOUZhYkMx?= =?utf-8?B?WkxMZFVSZmM5OHcydkNNWW0wRzEyQ2RvNUxiUUhYRmVWVDJLYnZURVVuZXNK?= =?utf-8?B?clMzSDY3ZE1ockZtL1N6a1dFQm5iQS9wL2loWE8vWEVaK2w0RGZHLzJWb1l3?= =?utf-8?B?WjVmL28rbGpSYkt2ekhLTDBRZ2JvSHRKc2xlZ2p1UHRrSWtMbVRJTC8wc0xS?= =?utf-8?B?WENoY2NXcjBITkJ5UkdweGFid2FQSld5SlVZbDhhN0ZVZFd3RHZMd01jdytm?= =?utf-8?B?aXRRMVRxamRXUlRRVzNzSi92OUVFQ1lndG1EOEdBTHU4YkVpcnh2UHNURnIz?= =?utf-8?B?TkpWcFA2Q3poZXRNdG5rZU4ra2Vxc3VTN0ZQMHNTMnNORkhzTm1wUjQ1Sk9n?= =?utf-8?B?bEQ2VTRNdVl4KzByVnduK3NrUURDblpaRmdJR1ZUQ1NZdWUrUnRBNmoydUt1?= =?utf-8?B?Ni9CY29kSk5QbFhYTm5xeDFqUU1iQWYvUDl6YUJHMlFCNkdzMitRT0x1OUxF?= =?utf-8?B?RkhXd3Nmd0QzZ0U5K3hKRGUzcnR4OGV3aDZVamYydVRFa2VkV0VVdThNQ0pC?= =?utf-8?B?cnJ3eWliWlhRaC92bkY1ZHAxTXAxQ2xidUJWcTJLL3JCUHl4d1BjRGdJekZU?= =?utf-8?B?d2hScGhXbGZPQ3Z2bWM1NGlyY3RJSko1QVFnS1dra2FrUFo1Yk9pVjdZSFZ3?= =?utf-8?B?WEZ2aDVIUmFiRjB4b1ZHWUI4cTRPWnYrMUNhK1lVeWFFU0huT3VPL292b2V5?= =?utf-8?B?ZHc9PQ==?= Content-ID: <566B7A777CDF814190551FC4950EB81C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6479.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae7b3edf-a9b2-43b8-37ba-08da7134f8e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 07:35:55.3690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jwyWW55oQDB5LQoFvVDtA9mS+Nhk0OdlZu5+F7afLGsKzOUVNthzAHh9fnQBoaFZ7khCg7TjZQPNPAeC/6rZdncG8QCgMU+1If215J1cm6c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6484 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_003608_096744_2268F46C X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 7/18/22 21:49, Sudip Mukherjee wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Jul 18, 2022 at 6:02 PM wrote: >> >> On 7/12/22 19:38, Sudip Mukherjee wrote: >>> [You don't often get email from sudip.mukherjee@sifive.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> Some flash chips which does not have a SFDP table can support Quad >>> Input Page Program. Enable it in hwcaps if defined. >>> > > > >>> diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h >>> index 58fbedc94080f..dde636bdb1a7c 100644 >>> --- a/drivers/mtd/spi-nor/core.h >>> +++ b/drivers/mtd/spi-nor/core.h >>> @@ -462,6 +462,7 @@ struct spi_nor_fixups { >>> * SPI_NOR_OCTAL_READ: flash supports Octal Read. >>> * SPI_NOR_OCTAL_DTR_READ: flash supports octal DTR Read. >>> * SPI_NOR_OCTAL_DTR_PP: flash supports Octal DTR Page Program. >>> + * SPI_NOR_QUAD_PP: flash supports Quad Input Page Program. >> >> You don't need this flag if your flash supports the 4-byte Address >> Instruction Table. Does you flash support it? Can you dump all the >> SFDP tables, please? > > Not sure what the correct way to dump sfdp is. I did this from sysfs. > > # cat sfdp | xxd > 00000000: 5346 4450 0601 01ff 0006 0110 3000 00ff SFDP........0... We really need a decoder for this :D. 5346 4450 - sfdp signature 0601 01ff - 2nd dword, 2 parameter tables 0006 0110 - BFPT of 16 dwords 3000 00ff - parameter header, 2nd dword > 00000010: 9d05 0103 8000 0002 ffff ffff ffff ffff ................ 9d05 0103 ID LSB = 0x9d, table with 3 dwords 8000 0002 ID MSB = 0x02 -> looks like a function specific vendor table So the flash does not support the 4-byte Address Instruction table, we can't retrieve the Quad PP from SFDP. > 00000020: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000030: e520 f9ff ffff ff0f 44eb 086b 083b 80bb . ......D..k.;.. > 00000040: feff ffff ffff 00ff ffff 44eb 0c20 0f52 ..........D.. .R > 00000050: 10d8 00ff 234a c900 82d8 11ce cccd 6846 ....#J........hF > 00000060: 7a75 7a75 f7ae d55c 4a42 2cff f030 faa9 zuzu...\JB,..0.. > 00000070: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000080: 5019 5016 9ff9 c064 8fef ffff P.P....d.... > > > -- > Regards > Sudip -- Cheers, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/