From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dell-paw-3.cambridge.redhat.com ([195.224.55.237] helo=passion.cambridge.redhat.com) by pentafluge.infradead.org with esmtp (Exim 3.22 #1 (Red Hat Linux)) id 16Wmff-0007qM-00 for ; Fri, 01 Feb 2002 23:00:39 +0000 From: David Woodhouse In-Reply-To: <3C5B0B3A.374C46F@comdev.cc> References: <3C5B0B3A.374C46F@comdev.cc> <3C5AD150.1A3B9AAE@comdev.cc> <20020201142405.79130.qmail@web20309.mail.yahoo.com> <9323.1012576311@redhat.com> <30239.1012586688@redhat.com> <3C5ADFC8.BD97CFFF@comdev.cc> <3C5AF025.F61F91F6@comdev.cc> To: Adam Wozniak Cc: linux-mtd@lists.infradead.org Subject: Re: debugging strategies for jffs2 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 01 Feb 2002 23:11:45 +0000 Message-ID: <4597.1012605105@redhat.com> Sender: linux-mtd-admin@lists.infradead.org Errors-To: linux-mtd-admin@lists.infradead.org List-Help: List-Post: List-Subscribe: , List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: adam.wozniak@comdev.cc said: > > The interesting bit to me is that the csize is 0x0000c000 > > and the dsize is 0x00000000. Is this perhaps causing problems? > > At fs/jffs2/gc.c,v 1.52, line 460: > fill: > ri.magic = JFFS2_MAGIC_BITMASK; > ri.nodetype = JFFS2_NODETYPE_INODE; > ri.totlen = sizeof(ri); > ri.hdr_crc = crc32(0, &ri, sizeof(struct jffs2_unknown_node)-4); > ri.ino = inode->i_ino; > ri.version = ++f->highest_version; > ri.offset = start; > ri.csize = end - start; > ri.dsize = 0; > ri.compr = JFFS2_COMPR_ZERO; > This seems backwards to me. Shouldn't ri.dsize = end-start and > ri.csize = 0 ??? Eep, yes that would probably do it. Well spotted. That obviously wasn't one of my more coherent days :) I've fixed it in v1.61 and v1.52.2.1 (on jffs2-2_4-branch) now - don't chuck your filesystem away though, I'll implement a workaround and ask you to test it. -- dwmw2