Re: [PATCH] [MTD] OneNAND: Add support for auto-placementofout-of-banddata

[Adrian Hunter <ext-adrian.hunter@nokia.com>]

ext Adrian Hunter wrote:
> ext Kyungmin Park wrote:
>>> +	writeend = mtd->oobsize;
>> We don't re-assign the 'writeend'. It cause the block is not clean. Since
>> JFFS2 send only 12 bytes but onenand writes until oobsize, actually 20
>> bytes with zero.
>> So this statement will be removed.
> 
> Yes, that was a typo.  The line should have been deleted when the previous
> line was deleted.

The statement still seems to be in the onenand tree.  Here is a patch to remove it.


>From 397419987d744ed971c74cfabae2eeac705f2fe0 Mon Sep 17 00:00:00 2001
From: Adrian Hunter <ext-adrian.hunter@nokia.com>
Date: Thu, 1 Feb 2007 09:59:41 +0200
Subject: [MTD] OneNAND: Remove line of code that was meant to be deleted

Iterations of the patch to add oob auto-placement support to
OneNAND left a line of code that was meant to have been deleted.

Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
 drivers/mtd/onenand/onenand_base.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 67efbc7..9ec28bb 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -1143,7 +1143,6 @@ static int onenand_fill_auto_oob(struct 
 			writeend += free->offset - lastgap;
 		lastgap = free->offset + free->length;
 	}
-	writeend = mtd->oobsize;
 	for (free = this->ecclayout->oobfree; free->length; ++free) {
 		int free_end = free->offset + free->length;
 		if (free->offset < writeend && free_end > writecol) {
-- 
1.4.3