From: Ferenc Havasi <havasi@inf.u-szeged.hu>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Obsolete nodes that are unlinked when possible
Date: Mon, 19 Mar 2007 11:55:41 +0100 [thread overview]
Message-ID: <45FE6C2D.40509@inf.u-szeged.hu> (raw)
In-Reply-To: <006e01c767ed$30828a40$0667a8c0@Jocke>
Joakim Tjernlund írta:
> Would bad things happen if an unclean reboot happens or will
> you just loose some performance?
>
There were many reason to set jffs2_can_mark_obsolete(c) to 0.
As Artem wrote if we would like to enable we have to mark not only the
node as obsolete but also the summary entry.
It is not too easy because of the followings:
- If you would like to modify the summary node on the flash it breaks
the CRC of the summary node. A solutions can be: the ACCURATE bit should
not included in the CRC. An other (worse) solution can be: when we
obsolate a node we overwrite the summary magic with 0, and at the next
mount the system will scan the erase block instead of using the summary
(peformance penalty).
- We also have to take care about not only the already written out
summary. The summary is written out when the jffs2 close an erase block.
If you want to mark obsolete a node in the unclosed eraseblock
(nextblock) you should obsolate it in the collected summary, too.
However it is not a big task, but also needs code modification and testing.
Ferenc
next prev parent reply other threads:[~2007-03-19 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 15:45 [PATCH] Obsolete nodes that are unlinked when possible Joakim Tjernlund
2007-03-16 16:14 ` Joakim Tjernlund
2007-03-16 16:27 ` Artem Bityutskiy
2007-03-16 17:04 ` Joakim Tjernlund
2007-03-16 17:26 ` Artem Bityutskiy
2007-03-19 10:55 ` Ferenc Havasi [this message]
2007-03-19 14:56 ` Joakim Tjernlund
2007-04-19 19:34 ` Joakim Tjernlund
2007-04-20 21:13 ` David Woodhouse
2007-04-21 8:56 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FE6C2D.40509@inf.u-szeged.hu \
--to=havasi@inf.u-szeged.hu \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox