public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Egor N. Martovetsky" <egor@pasemi.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: olof@lixom.net, Thomas Gleixner <tglx@linutronix.de>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [2.6.23] nand_flash_dev - add manufacturer ID
Date: Thu, 05 Jul 2007 11:55:29 -0700	[thread overview]
Message-ID: <468D3EA1.80704@pasemi.com> (raw)
In-Reply-To: <1183658637.2756.9.camel@shinybook.infradead.org>

Ok.

hopefully there will not be too many manufacturer-specific or 
device-specific
hacks needed in the future.

David Woodhouse wrote:

>On Thu, 2007-07-05 at 10:44 -0700, Egor N. Martovetsky wrote:
>  
>
>>Right now, there is no way to uniquely identify the device and assign
>>options to it.  I saw that as a potential future problem.  Instead of
>>adding code to nand_get_flash_type() to special treat our device, I
>>thought it would be better to provide a general mechanism, which can
>>be used to prevent this in the future.  This only affects the flashes
>>that need to be special cased.  For the rest of them, manufacturer ID
>>is not specified and the match occurs purely on Device ID - as
>>before. 
>>    
>>
>
>Yeah, I can see the sense in what you're saying. I'm dubious about
>having to duplicate various chip idents just to give separate options
>though, when a single entry in the table along with some
>manufacturer-specific code to mask out/in certain features would do the
>same thing.
>
>  
>


-- 
Egor N. Martovetsky

      reply	other threads:[~2007-07-05 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 23:54 [PATCH] [2.6.23] nand_flash_dev - add manufacturer ID Egor Martovetsky
2007-07-04  0:03 ` David Woodhouse
2007-07-04  5:55   ` Thomas Gleixner
2007-07-05 17:44     ` Egor N. Martovetsky
2007-07-05 18:03       ` David Woodhouse
2007-07-05 18:55         ` Egor N. Martovetsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468D3EA1.80704@pasemi.com \
    --to=egor@pasemi.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=olof@lixom.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox