From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elcamino.pasemi.com ([67.155.108.98]) by canuck.infradead.org with esmtp (Exim 4.63 #1 (Red Hat Linux)) id 1I6WUE-0008GJ-Bt for linux-mtd@lists.infradead.org; Thu, 05 Jul 2007 14:55:34 -0400 Message-ID: <468D3EA1.80704@pasemi.com> Date: Thu, 05 Jul 2007 11:55:29 -0700 From: "Egor N. Martovetsky" MIME-Version: 1.0 To: David Woodhouse Subject: Re: [PATCH] [2.6.23] nand_flash_dev - add manufacturer ID References: <200707032354.l63Ns7gh010492@escobita.pasemi.com> <1183507424.29081.73.camel@shinybook.infradead.org> <1183528554.3291.60.camel@chaos> <468D2DF8.4050609@pasemi.com> <1183658637.2756.9.camel@shinybook.infradead.org> In-Reply-To: <1183658637.2756.9.camel@shinybook.infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: olof@lixom.net, Thomas Gleixner , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ok. hopefully there will not be too many manufacturer-specific or device-specific hacks needed in the future. David Woodhouse wrote: >On Thu, 2007-07-05 at 10:44 -0700, Egor N. Martovetsky wrote: > > >>Right now, there is no way to uniquely identify the device and assign >>options to it. I saw that as a potential future problem. Instead of >>adding code to nand_get_flash_type() to special treat our device, I >>thought it would be better to provide a general mechanism, which can >>be used to prevent this in the future. This only affects the flashes >>that need to be special cased. For the rest of them, manufacturer ID >>is not specified and the match occurs purely on Device ID - as >>before. >> >> > >Yeah, I can see the sense in what you're saying. I'm dubious about >having to duplicate various chip idents just to give separate options >though, when a single entry in the table along with some >manufacturer-specific code to mask out/in certain features would do the >same thing. > > > -- Egor N. Martovetsky