From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Ben Dooks <ben@fluff.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] S3C24XX large page NAND support
Date: Mon, 23 Jul 2007 17:01:18 +0200 [thread overview]
Message-ID: <46A4C2BE.3050108@parrot.com> (raw)
In-Reply-To: <20070723134617.GA19071@fluff.org.uk>
Hi Ben,
Ben Dooks wrote:
> On Thu, Jul 12, 2007 at 12:04:03PM +0200, Matthieu CASTET wrote:
> [snip]
>>>
>>> - nmtd->scan_res = nand_scan(&nmtd->mtd, (sets) ? sets->nr_chips : 1);
>>> + nmtd->scan_res = nand_scan_ident(&nmtd->mtd,
>>> + (sets) ? sets->nr_chips : 1);
>>>
>>> if (nmtd->scan_res == 0) {
>>> + s3c2410_nand_update_chip(info, nmtd);
>>> + nand_scan_tail(&nmtd->mtd);
>>> s3c2410_nand_add_partition(info, nmtd, sets);
>>> }
>> Shouldn't nand_scan_ident and nand_scan_tail be used here ?
>
> Sorry, do you mean that they should be used here (and they are
> being used in this code) or do you mean that you do not think
> that these two are to be used here?
>
Sorry for the noise, I misread the patch and was thinking nand_scan was
still used.
Again sorry.
Matthieu
prev parent reply other threads:[~2007-07-23 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 23:11 [PATCH] S3C24XX large page NAND support Ben Dooks
2007-07-12 10:04 ` Matthieu CASTET
2007-07-23 13:46 ` Ben Dooks
2007-07-23 15:01 ` Matthieu CASTET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A4C2BE.3050108@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=ben@fluff.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox