From: "M8 (Servaes Joordens)" <Servaes.Joordens@m8.nl>
To: linux-mtd@lists.infradead.org
Subject: Bug in cmdlinepart.c?
Date: Fri, 21 Sep 2007 09:59:30 +0200 [thread overview]
Message-ID: <46F379E2.2090402@m8.nl> (raw)
Dear sirs,
I asked this question in the forum on blackfin.uclinux.org and the gave
me this email addres to post my mail to.
In drivers/mtd/cmdlinepart.c there is the following piece of code:
if( strncmp(s, "ro", 2) == 0 )
{
mask_flags |= MTD_WRITEABLE;
s+=2;
}
Is this correct? When the partition is defined to be read-only (ro) the
MTD_WRITEABLE flag is set? I guess this should be:
if( strncmp(s, "ro", 2) == 0 )
{
mask_flags &= (~MTD_WRITEABLE); // disable the writeability
s+=2;
}else
{
mask_flags |= MTD_WRITEABLE; // enable the writeability
}
I hope you can answer my question. Thanks in advance.
Servaes Joordens
M8
--
Servaes Joordens
-------------------------------------------
M8
Tappersweg 29
2031ET Haarlem
The Netherlands
Tel: +31 23 5311122
Mob: +31 6 51183379
Fax: +31 23 5322388
VAT-ID: nl-813029090B01
kvk: 34131430 Haarlem
reply other threads:[~2007-09-21 9:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F379E2.2090402@m8.nl \
--to=servaes.joordens@m8.nl \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox