From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.sigma-star.at ([95.130.255.111]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eQqGx-00036b-Aj for linux-mtd@lists.infradead.org; Mon, 18 Dec 2017 07:55:42 +0000 From: Richard Weinberger To: Miquel Raynal Cc: Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: Fix mtd_check_oob_ops() Date: Mon, 18 Dec 2017 08:55:48 +0100 Message-ID: <4707993.PQVFgyHhAj@blindfold> In-Reply-To: <20171218072628.17977-1-miquel.raynal@free-electrons.com> References: <20171218072628.17977-1-miquel.raynal@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am Montag, 18. Dezember 2017, 08:26:28 CET schrieb Miquel Raynal: > The mtd_check_oob_ops() helper verifies if the operation defined by the > user is correct. > > Fix the check that verifies if the entire requested area exists. This > check is too restrictive and will fail anytime the last data byte of the > very last page is included in an operation. > > Fixes: 5cdd929da53d ("mtd: Add sanity checks in mtd_write/read_oob()") > Signed-off-by: Miquel Raynal Thanks for spotting and fixing this, Miquel. > --- > drivers/mtd/mtdcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index f80e911b8843..73b605577447 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -1114,7 +1114,7 @@ static int mtd_check_oob_ops(struct mtd_info *mtd, > loff_t offs, if (!ops->oobbuf) > ops->ooblen = 0; > > - if (offs < 0 || offs + ops->len >= mtd->size) > + if (offs < 0 || offs + ops->len > mtd->size) > return -EINVAL; > > if (ops->ooblen) { Thanks, //richard