ubi-utils: unubi fixes and enhancements

ubi-utils: unubi fixes and enhancements

[Frank Haverkamp]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Hi Artem,

some time ago Drake Dawsett, a student working for us, has done some
bug-fixes and enhancements to the unubi tool. He forgot to send them out
before he left us. I have reworked them for integration:

  git://git.infradead.org/users/haver/mtd-utils.git

Please have a look, and pull them if you are fine with them.

Thanks,

Frank

-- 
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
Boeblingen, Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher, Sitz der Gesellschaft: Böblingen,
Registergericht: Amtsgericht Stuttgart, HRB 243294

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5269 bytes --]

Re: ubi-utils: unubi fixes and enhancements

[Artem Bityutskiy]

On Mon, 2007-11-05 at 13:58 +0100, Frank Haverkamp wrote:
> Hi Artem,
> 
> some time ago Drake Dawsett, a student working for us, has done some
> bug-fixes and enhancements to the unubi tool. He forgot to send them out
> before he left us. I have reworked them for integration:
> 
>   git://git.infradead.org/users/haver/mtd-utils.git
> 
> Please have a look, and pull them if you are fine with them.

Hi guys, sorry, I was away, will handle this soon.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: ubi-utils: unubi fixes and enhancements

[Artem Bityutskiy]

Artem Bityutskiy wrote:
> On Mon, 2007-11-05 at 13:58 +0100, Frank Haverkamp wrote:
>> Hi Artem,
>>
>> some time ago Drake Dawsett, a student working for us, has done some
>> bug-fixes and enhancements to the unubi tool. He forgot to send them out
>> before he left us. I have reworked them for integration:
>>
>>   git://git.infradead.org/users/haver/mtd-utils.git
>>
>> Please have a look, and pull them if you are fine with them.
> 
> Hi guys, sorry, I was away, will handle this soon.

It does not compile for me:

gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings -W 
-std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o nand2bin.o ./src/nand2bin.c -g 
-Wp,-MD,.nand2bin.c.dep
gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings -W 
-std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o nandcorr.o ./src/nandcorr.c -g 
-Wp,-MD,.nandcorr.c.dep
gcc  -o nand2bin nand2bin.o nandecc.o nandcorr.o
make[1]: *** No rule to make target `src/eb_chain.h', needed by `unubi.o'.  Stop.
make[1]: Leaving directory `/home/dedekind/git/mtd-utils.git/ubi-utils'
make: *** [all] Error 2

Could you please fix this and also rebase against newer mtd-utils.git?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: ubi-utils: unubi fixes and enhancements

[Frank Haverkamp]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hi Artem,

On Mon, 2007-11-19 at 15:38 +0200, Artem Bityutskiy wrote:

> It does not compile for me:
> 
> gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings -W 
> -std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o nand2bin.o ./src/nand2bin.c -g 
> -Wp,-MD,.nand2bin.c.dep
> gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings -W 
> -std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o nandcorr.o ./src/nandcorr.c -g 
> -Wp,-MD,.nandcorr.c.dep
> gcc  -o nand2bin nand2bin.o nandecc.o nandcorr.o
> make[1]: *** No rule to make target `src/eb_chain.h', needed by `unubi.o'.  Stop.
> make[1]: Leaving directory `/home/dedekind/git/mtd-utils.git/ubi-utils'
> make: *** [all] Error 2
> 
> Could you please fix this and also rebase against newer mtd-utils.git?
> 
currently I am little busy. I will let you know when I have fixed and
rebased the code. Thanks for looking into it.

Regards,

Frank


-- 
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
Boeblingen, Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher, Sitz der Gesellschaft: Böblingen,
Registergericht: Amtsgericht Stuttgart, HRB 243294

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5269 bytes --]

Re: ubi-utils: unubi fixes and enhancements

[Frank Haverkamp]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

Hi Artem,

On Mon, 2007-11-19 at 15:38 +0200, Artem Bityutskiy wrote:
> It does not compile for me:
> 
> gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings
> -W 
> -std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o
> nandcorr.o ./src/nandcorr.c -g 
> -Wp,-MD,.nandcorr.c.dep
> gcc  -o nand2bin nand2bin.o nandecc.o nandcorr.o
> make[1]: *** No rule to make target `src/eb_chain.h', needed by
> `unubi.o'.  Stop.
> make[1]: Leaving directory
> `/home/dedekind/git/mtd-utils.git/ubi-utils'
> make: *** [all] Error 2

I had removed the src/eb_chain.h file. I renewed my git and tried my
patches with a clean checkout. It works for me. Can it be that our
dependency-checking is broken and you did not do make clean before you
tried compiling?

Regards,

Frank

-- 
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
Boeblingen, Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher, Sitz der Gesellschaft: Böblingen,
Registergericht: Amtsgericht Stuttgart, HRB 243294

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5269 bytes --]

Re: ubi-utils: unubi fixes and enhancements

[Artem Bityutskiy]

Frank Haverkamp wrote:
>> gcc -I./inc -I./src -I../include -O2 -g -Wall -Werror -Wwrite-strings
>> -W 
>> -std=gnu99 -DPACKAGE_VERSION=\"1.0\" -g -c -o
>> nandcorr.o ./src/nandcorr.c -g 
>> -Wp,-MD,.nandcorr.c.dep
>> gcc  -o nand2bin nand2bin.o nandecc.o nandcorr.o
>> make[1]: *** No rule to make target `src/eb_chain.h', needed by
>> `unubi.o'.  Stop.
>> make[1]: Leaving directory
>> `/home/dedekind/git/mtd-utils.git/ubi-utils'
>> make: *** [all] Error 2
> 
> I had removed the src/eb_chain.h file. I renewed my git and tried my
> patches with a clean checkout. It works for me. Can it be that our
> dependency-checking is broken and you did not do make clean before you
> tried compiling?

Sorry Frank, my fault. Committed, thank you.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)