From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
dmaengine@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 05/12] mtd: sh_flctl: use dmaengine_terminate_all() API
Date: Sat, 11 Oct 2014 20:19:50 +0300 [thread overview]
Message-ID: <4775968.otKQDIzYx4@avalon> (raw)
In-Reply-To: <1413042040-28222-5-git-send-email-vinod.koul@intel.com>
On Saturday 11 October 2014 21:10:33 Vinod Koul wrote:
> The drivers should use dmaengine_terminate_all() API instead of
> accessing the device_control which will be deprecated soon
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/mtd/nand/sh_flctl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index c067023..0ed7c60 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -395,7 +395,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl
> *flctl, unsigned long *buf, msecs_to_jiffies(3000));
>
> if (ret <= 0) {
> - chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> + dmaengine_terminate_all(chan);
> dev_err(&flctl->pdev->dev, "wait_for_completion_timeout\n");
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-10-11 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
2014-10-27 16:43 ` Linus Walleij
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
2014-10-11 17:19 ` Laurent Pinchart [this message]
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4775968.otKQDIzYx4@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=computersforpeace@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).