* [PATCH 00/12] dmaengine: remove users of device_control
@ 2014-10-11 15:39 Vinod Koul
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vinod Koul @ 2014-10-11 15:39 UTC (permalink / raw)
To: dmaengine
Cc: linux-fbdev, Rafael J. Wysocki, Lars-Peter Clausen, Takashi Iwai,
Daniel Vetter, Linus Walleij, Nicolas Ferre, alsa-devel,
Jaroslav Kysela, linux-ide, linux-mtd, linux-spi, Jiri Slaby,
Laurent Pinchart, Vinod Koul, Jingoo Han, Tomi Valkeinen,
Ezequiel Garcia, Jean-Christophe Plagniol-Villard, linux-media,
Alexander Stein, linux-serial, Bartlomiej Zolnierkiewicz,
Sascha Hauer, Mark Brown, Dan Williams, linux-arm-kernel,
Greg Kroah-Hartman, linux-usb, Liam Girdwood, Felipe Balbi,
linux-kernel, Denis Carikli, Kyungmin Park, Viresh Kumar, netdev,
Tejun Heo, Brian Norris, David Woodhouse, Guennadi Liakhovetski,
Mauro Carvalho Chehab
The recent discussion [1] on the API have resulted in moving away from
device_control ioctl method to proper channel APIs.
There are still few users on the device_control which should use the wrappers
existing rather than access device_control.
This will aid us in deprecating and removing device_control, possibly after
the merge window.
These can be merged thru respective subsystem tree or dmaengine tree. Either
way please just let me know.
Feng's kbuild has tested these as well [2]
[1]: http://www.spinics.net/lists/dmaengine/msg02212.html
[2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup
Vinod Koul (12):
pata_arasan_cf: use dmaengine_terminate_all() API
dmaengine: coh901318: use dmaengine_terminate_all() API
[media] V4L2: mx3_camer: use dmaengine_pause() API
mtd: fsmc_nand: use dmaengine_terminate_all() API
mtd: sh_flctl: use dmaengine_terminate_all() API
net: ks8842: use dmaengine_terminate_all() API
spi/atmel: use dmaengine_terminate_all() API
spi/spi-dw-mid.c: use dmaengine_slave_config() API
serial: sh-sci: use dmaengine_terminate_all() API
usb: musb: ux500_dma: use dmaengine_xxx() APIs
ASoC: txx9: use dmaengine_terminate_all() API
video: mx3fb: use dmaengine_terminate_all() API
drivers/ata/pata_arasan_cf.c | 5 ++---
drivers/dma/coh901318.c | 2 +-
drivers/media/platform/soc_camera/mx3_camera.c | 6 ++----
drivers/mtd/nand/fsmc_nand.c | 2 +-
drivers/mtd/nand/sh_flctl.c | 2 +-
drivers/net/ethernet/micrel/ks8842.c | 6 ++----
drivers/spi/spi-atmel.c | 6 ++----
drivers/spi/spi-dw-mid.c | 6 ++----
drivers/tty/serial/sh-sci.c | 2 +-
drivers/usb/musb/ux500_dma.c | 7 ++-----
drivers/video/fbdev/mx3fb.c | 3 +--
sound/soc/txx9/txx9aclc.c | 7 +++----
12 files changed, 20 insertions(+), 34 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
@ 2014-10-11 15:40 ` Vinod Koul
2014-10-27 16:43 ` Linus Walleij
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2014-10-11 15:40 UTC (permalink / raw)
To: dmaengine
Cc: Mark Brown, Vinod Koul, Linus Walleij, Jingoo Han, linux-kernel,
Bartlomiej Zolnierkiewicz, linux-mtd, Brian Norris,
David Woodhouse
The drivers should use dmaengine_terminate_all() API instead of
accessing the device_control which will be deprecated soon
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
drivers/mtd/nand/fsmc_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
index 1550692..7a91587 100644
--- a/drivers/mtd/nand/fsmc_nand.c
+++ b/drivers/mtd/nand/fsmc_nand.c
@@ -605,7 +605,7 @@ static int dma_xfer(struct fsmc_nand_data *host, void *buffer, int len,
wait_for_completion_timeout(&host->dma_access_complete,
msecs_to_jiffies(3000));
if (ret <= 0) {
- chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
+ dmaengine_terminate_all(chan);
dev_err(host->dev, "wait_for_completion_timeout\n");
if (!ret)
ret = -ETIMEDOUT;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 05/12] mtd: sh_flctl: use dmaengine_terminate_all() API
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
@ 2014-10-11 15:40 ` Vinod Koul
2014-10-11 17:19 ` Laurent Pinchart
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2014-10-11 15:40 UTC (permalink / raw)
To: dmaengine
Cc: Laurent Pinchart, Rafael J. Wysocki, Vinod Koul, Jingoo Han,
linux-kernel, linux-mtd, Ezequiel Garcia, Brian Norris,
David Woodhouse
The drivers should use dmaengine_terminate_all() API instead of
accessing the device_control which will be deprecated soon
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
drivers/mtd/nand/sh_flctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index c067023..0ed7c60 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -395,7 +395,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
msecs_to_jiffies(3000));
if (ret <= 0) {
- chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
+ dmaengine_terminate_all(chan);
dev_err(&flctl->pdev->dev, "wait_for_completion_timeout\n");
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 05/12] mtd: sh_flctl: use dmaengine_terminate_all() API
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
@ 2014-10-11 17:19 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-10-11 17:19 UTC (permalink / raw)
To: Vinod Koul
Cc: Laurent Pinchart, Rafael J. Wysocki, Jingoo Han, linux-kernel,
linux-mtd, Ezequiel Garcia, dmaengine, Brian Norris,
David Woodhouse
On Saturday 11 October 2014 21:10:33 Vinod Koul wrote:
> The drivers should use dmaengine_terminate_all() API instead of
> accessing the device_control which will be deprecated soon
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/mtd/nand/sh_flctl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index c067023..0ed7c60 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -395,7 +395,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl
> *flctl, unsigned long *buf, msecs_to_jiffies(3000));
>
> if (ret <= 0) {
> - chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> + dmaengine_terminate_all(chan);
> dev_err(&flctl->pdev->dev, "wait_for_completion_timeout\n");
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/12] dmaengine: remove users of device_control
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
@ 2014-10-15 15:58 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2014-10-15 15:58 UTC (permalink / raw)
To: dmaengine
Cc: linux-fbdev, Rafael J. Wysocki, Lars-Peter Clausen, Takashi Iwai,
Daniel Vetter, Linus Walleij, Nicolas Ferre, alsa-devel,
Jaroslav Kysela, linux-ide, linux-mtd, linux-spi, Jiri Slaby,
Laurent Pinchart, Jingoo Han, Tomi Valkeinen, Ezequiel Garcia,
Jean-Christophe Plagniol-Villard, linux-media, Alexander Stein,
linux-serial, Bartlomiej Zolnierkiewicz, Sascha Hauer, Mark Brown,
Dan Williams, linux-arm-kernel, Greg Kroah-Hartman, linux-usb,
Liam Girdwood, Felipe Balbi, linux-kernel, Denis Carikli,
Kyungmin Park, Viresh Kumar, netdev, Tejun Heo, Brian Norris,
David Woodhouse, Guennadi Liakhovetski, Mauro Carvalho Chehab
On Sat, Oct 11, 2014 at 09:09:33PM +0530, Vinod Koul wrote:
> The recent discussion [1] on the API have resulted in moving away from
> device_control ioctl method to proper channel APIs.
> There are still few users on the device_control which should use the wrappers
> existing rather than access device_control.
> This will aid us in deprecating and removing device_control, possibly after
> the merge window.
>
> These can be merged thru respective subsystem tree or dmaengine tree. Either
> way please just let me know.
Applying to dmaengine-next with acks recived, dropping the ones which are
applied by respective folks
--
~Vinod
>
> Feng's kbuild has tested these as well [2]
>
> [1]: http://www.spinics.net/lists/dmaengine/msg02212.html
> [2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup
>
> Vinod Koul (12):
> pata_arasan_cf: use dmaengine_terminate_all() API
> dmaengine: coh901318: use dmaengine_terminate_all() API
> [media] V4L2: mx3_camer: use dmaengine_pause() API
> mtd: fsmc_nand: use dmaengine_terminate_all() API
> mtd: sh_flctl: use dmaengine_terminate_all() API
> net: ks8842: use dmaengine_terminate_all() API
> spi/atmel: use dmaengine_terminate_all() API
> spi/spi-dw-mid.c: use dmaengine_slave_config() API
> serial: sh-sci: use dmaengine_terminate_all() API
> usb: musb: ux500_dma: use dmaengine_xxx() APIs
> ASoC: txx9: use dmaengine_terminate_all() API
> video: mx3fb: use dmaengine_terminate_all() API
>
> drivers/ata/pata_arasan_cf.c | 5 ++---
> drivers/dma/coh901318.c | 2 +-
> drivers/media/platform/soc_camera/mx3_camera.c | 6 ++----
> drivers/mtd/nand/fsmc_nand.c | 2 +-
> drivers/mtd/nand/sh_flctl.c | 2 +-
> drivers/net/ethernet/micrel/ks8842.c | 6 ++----
> drivers/spi/spi-atmel.c | 6 ++----
> drivers/spi/spi-dw-mid.c | 6 ++----
> drivers/tty/serial/sh-sci.c | 2 +-
> drivers/usb/musb/ux500_dma.c | 7 ++-----
> drivers/video/fbdev/mx3fb.c | 3 +--
> sound/soc/txx9/txx9aclc.c | 7 +++----
> 12 files changed, 20 insertions(+), 34 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
@ 2014-10-27 16:43 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-10-27 16:43 UTC (permalink / raw)
To: Vinod Koul
Cc: Mark Brown, Bartlomiej Zolnierkiewicz, Jingoo Han,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
dmaengine, Brian Norris, David Woodhouse
On Sat, Oct 11, 2014 at 5:40 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> The drivers should use dmaengine_terminate_all() API instead of
> accessing the device_control which will be deprecated soon
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-27 16:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
2014-10-27 16:43 ` Linus Walleij
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
2014-10-11 17:19 ` Laurent Pinchart
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).