From: Scott Wood <scottwood@freescale.com>
To: Stefan Roese <sr@denx.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: Fix physmap_of to not exit upon unsuccessful partition scan
Date: Tue, 12 Feb 2008 13:27:10 -0600 [thread overview]
Message-ID: <47B1F30E.4000509@freescale.com> (raw)
In-Reply-To: <200802122015.08811.sr@denx.de>
Stefan Roese wrote:
> On Tuesday 12 February 2008, Scott Wood wrote:
>> Under what conditions are you actually seeing this fail?
>
> When CONFIG_MTD_REDBOOT_PARTS is not defined for example it returns with -22
> (EINVAL).
Ah, I see -- it seems the cmdline partition code behaves differently
than the redboot code.
Your patch changes it to treat zero as success, however -- which breaks
some other cases. The test should be "err <= 0", which is what
parse_mtd_partiitions() itself uses in its loop.
-Scott
next prev parent reply other threads:[~2008-02-12 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 16:03 [PATCH] mtd: Fix physmap_of to not exit upon unsuccessful partition scan Stefan Roese
2008-02-12 18:06 ` Scott Wood
2008-02-12 19:15 ` Stefan Roese
2008-02-12 19:27 ` Scott Wood [this message]
2008-02-12 19:37 ` Stefan Roese
2008-02-14 12:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B1F30E.4000509@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox