From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] [MTD] [RESEND] MAPS: add support for Nvidia MCP55 to ck804xrom
Date: Tue, 22 Apr 2008 19:21:44 +0200 [thread overview]
Message-ID: <480E1EA8.9040101@gmx.net> (raw)
In-Reply-To: <1208884343.9212.633.camel@pmac.infradead.org>
On 22.04.2008 19:12, David Woodhouse wrote:
> On Wed, 2008-01-16 at 15:45 +0100, Carl-Daniel Hailfinger wrote:
>
>> [PATCH] [MTD] MAPS: add support for Nvidia MCP55 to ck804xrom
>>
>> This patch extends the existing MAPS driver for the Nvidia CK804 chipset
>> (ck804xrom.c) to also work on the Nvidia MCP55 chipset. As both chipsets
>> are rather similar, suporting them both with the same driver is easy.
>>
>> The patch is not ready for inclusion yet, it needs some codingstyle care
>> and probably better comments. The indenting is wrong at some points to
>> keep the diff minimal for a first review. I will post a better version
>> once I get some comments.
>>
>
> I fixed that and applied it anyway.
>
Thank you!
>> + { PCI_VENDOR_ID_NVIDIA, 0x0363,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0364,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0365,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0366,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x03607,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>>
>
> I fixed that too; I assume the last ID should have been 0x367?
>
Indeed, my bad.
Regards,
Carl-Daniel
prev parent reply other threads:[~2008-04-22 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 14:45 [PATCH] [MTD] [RESEND] MAPS: add support for Nvidia MCP55 to ck804xrom Carl-Daniel Hailfinger
2008-04-22 17:12 ` David Woodhouse
2008-04-22 17:21 ` Carl-Daniel Hailfinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E1EA8.9040101@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox