Re: [PATCH] [MTD] [RESEND] MAPS: add support for Nvidia MCP55 to ck804xrom

Carl-Daniel Hailfinger
2008-04-22T17:21:48Z

On 22.04.2008 19:12, David Woodhouse wrote:
> On Wed, 2008-01-16 at 15:45 +0100, Carl-Daniel Hailfinger wrote:
>
>> [PATCH] [MTD] MAPS: add support for Nvidia MCP55 to ck804xrom
>>
>> This patch extends the existing MAPS driver for the Nvidia CK804 chipset
>> (ck804xrom.c) to also work on the Nvidia MCP55 chipset. As both chipsets
>> are rather similar, suporting them both with the same driver is easy.
>>
>> The patch is not ready for inclusion yet, it needs some codingstyle care
>> and probably better comments. The indenting is wrong at some points to
>> keep the diff minimal for a first review. I will post a better version
>> once I get some comments.
>>
>
> I fixed that and applied it anyway.
>

Thank you!

>> + { PCI_VENDOR_ID_NVIDIA, 0x0363,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0364,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0365,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x0366,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>> + { PCI_VENDOR_ID_NVIDIA, 0x03607,
>> + PCI_ANY_ID, PCI_ANY_ID, 2 }, /* nvidia mcp55 */
>>
>
> I fixed that too; I assume the last ID should have been 0x367?
>

Indeed, my bad.

Regards,
Carl-Daniel