Re: [PATCH] fix cfi for collie flash

David Woodhouse
2008-04-23T01:22:13Z

On Wed, 2008-04-23 at 03:16 +0200, Thomas Kunze wrote:
> Again with (hopefully) no line wrappings.

Nope. In general, it's worth sending things to yourself first, saving
them from the email you receive, and checking that you can apply them to
a clean tree. Only then do you send it to other people.

Also, ...

ERROR: use tabs not spaces
#65: FILE: drivers/mtd/chips/cfi_cmdset_0001.c:622:
+ /* if numregions=0 we have one big partition */$

ERROR: use tabs not spaces
#66: FILE: drivers/mtd/chips/cfi_cmdset_0001.c:623:
+ if(!numparts)$

ERROR: space required before the open parenthesis '('
#66: FILE: drivers/mtd/chips/cfi_cmdset_0001.c:623:
+ if(!numparts)

ERROR: use tabs not spaces
#67: FILE: drivers/mtd/chips/cfi_cmdset_0001.c:624:
+ numparts = 1;$

total: 4 errors, 0 warnings, 12 lines checked

I've fixed it for now, but don't let that stop you from becoming
familiar with scripts/checkpatch.pl and working out how to make your
mailer behave :)

Thanks for the patch.
--
dwmw2