public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Anders Grafström" <grfstrm@users.sourceforge.net>
To: Alexander Belyakov <abelyako@mail.ru>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Nicolas Pitre <nico@cam.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Alexander Belyakov <abelyako@gmail.com>
Subject: Re: [RFC/PATCH][NOR] Fix cfi_cmdset_0001.c FL_SYNCING race
Date: Mon, 05 May 2008 14:47:23 +0200	[thread overview]
Message-ID: <481F01DB.60603@users.sourceforge.net> (raw)
In-Reply-To: <E1Jsaol-0007Gx-00.abelyako-mail-ru@f188.mail.ru>

Alexander Belyakov wrote:
> +	/* Prevent setting state FL_SYNCING for chip in suspended state. */
> +	if (FL_SYNCING == mode && FL_READY != chip->oldstate)

The operand order differs from the rest of the code.
Apart from that I think it looks ok.

Anders

  reply	other threads:[~2008-05-05 12:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04  9:47 [RFC/PATCH][NOR] Fix cfi_cmdset_0001.c FL_SYNCING race Alexander Belyakov
2008-05-05 12:47 ` Anders Grafström [this message]
2008-05-06  9:41   ` Alexander Belyakov
  -- strict thread matches above, loose matches on Subject: below --
2008-04-29  9:37 Alexander Belyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481F01DB.60603@users.sourceforge.net \
    --to=grfstrm@users.sourceforge.net \
    --cc=abelyako@gmail.com \
    --cc=abelyako@mail.ru \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox