From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-out.m-online.net ([212.18.0.9]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1K5PDK-0006C9-J8 for linux-mtd@lists.infradead.org; Sun, 08 Jun 2008 18:02:10 +0000 Message-ID: <484C1E8F.4010900@grandegger.com> Date: Sun, 08 Jun 2008 20:01:51 +0200 From: Wolfgang Grandegger MIME-Version: 1.0 To: David Woodhouse Subject: Re: [PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules References: <4847A8DA.6010406@grandegger.com> <1212825701.32207.403.camel@pmac.infradead.org> In-Reply-To: <1212825701.32207.403.camel@pmac.infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, Anton Vorontsov , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , David Woodhouse wrote: > On Thu, 2008-06-05 at 10:50 +0200, Wolfgang Grandegger wrote: >> [NAND] driver extension to support NAND on TQM85xx modules >> >> This patch extends the FSL UPM NAND driver from Anton Vorontsov to >> support NAND on the TQM85xx modules. Unfortunately, the hardware does >> not support the R/B pins of the NAND chip and therefore the specified >> maximum delay time must used. It therefore re-introduces the chip-delay >> property. >> >> Note: this patch is based on various patches from Anton Vorontsov posted >> to this list: >> >> http://ozlabs.org/pipermail/linuxppc-dev/2008-April/055587.html. > > Do you also want me to apply that patch (on which this one depends)? > It says 'Signed-off-by: not yet' ... Anton has already answer that question. > You should probably comment on the removal of the OF_GPIO dependency. It > looks fine, since the relevant functions all get stubbed out and will do > the right thing, but it's worth a comment in the commit text. OK, will do so. Wolfgang.