public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Iwo Mergler <iwo@call-direct.com.au>
To: linux-mtd@lists.infradead.org
Cc: joern@logfs.org, dwmw2@infradead.org,
	Alexey Korolev <akorolev@infradead.org>
Subject: Re: [BUG] JFFS2 power loss recovery issues on NAND
Date: Tue, 17 Jun 2008 11:03:22 +1000	[thread overview]
Message-ID: <48570D5A.1050906@call-direct.com.au> (raw)
In-Reply-To: <alpine.LFD.1.10.0806101438520.27550@casper.infradead.org>

Alexey Korolev wrote:
> JFFS2 ignores read errors from NAND since it has own CRC. On attempt to
> read fragment from first 256 bytes JFFS2 detects CRC error as this
> region has been improperly corrected and considers
> node as invalid. Rest data on page is considered as good. 
>
> So if we write new file during power loss and we have several nodes in
> page, we may face bad case with hole in the middle of the file after
> power loss. It is a bug. 
>
> The attached picture may explain the issue better. 
>
>
> So for now it is clear how JFFS2 fails. It is not obvious how to fix it. 
> Do you have any suggestions or ideas how it could be fixed?
> Would it be a good idea do hack JFFS2 in order to read data one more
> time but without ECC correction in case of failed read?
>   
Alexey,

I know of at least one hardware ECC implementation which can flag
errors within the ECC bytes separately. In other words, not all 
implementations
will detect/correct bit errors in the case of a ECC write error.

About how to fix it - what about making the reading without ECC the default
and only re-reading with ECC if JFFS2 finds an invalid checksum?

Kind regards,

Iwo

  reply	other threads:[~2008-06-17  1:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 13:57 [BUG] JFFS2 power loss recovery issues on NAND Alexey Korolev
2008-06-17  1:03 ` Iwo Mergler [this message]
2008-06-17  8:13   ` Matthieu CASTET
2008-06-17  9:24     ` Jörn Engel
2008-06-17 16:00       ` Alexey Korolev
2008-06-17 16:57         ` Jörn Engel
2008-06-17 23:51     ` Iwo Mergler
2008-06-18 12:19       ` Jamie Lokier
2008-06-18 12:33         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48570D5A.1050906@call-direct.com.au \
    --to=iwo@call-direct.com.au \
    --cc=akorolev@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=joern@logfs.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox