From: "Andrew E. Mileski" <andrewm@isoar.ca>
To: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] nand_wait_ready() timeout scaling
Date: Mon, 14 Jul 2008 16:32:25 -0400 [thread overview]
Message-ID: <487BB7D9.4070505@isoar.ca> (raw)
In-Reply-To: <1209583375-11136-1-git-send-email-andrewm@isoar.ca>
Andrew E. Mileski wrote:
> The nand_wait_ready() timeout was hardcoded to 2 jiffies, which does not
> scale with the system timer frequency. Using a guess of a 250 Hz system
> timer frequency, I believe the timeout was meant to be 8 ms.
Just a heads-up for those similarly banging their heads trying to get
NAND to work for them, that I think I've also found 2 instances of a
bug: not waiting tWB before calling nand_wait_ready() in nand_base.c
nand_do_read_ops()
nand_do_read_oob()
I almost think the ndelay(tWB) should be in nand_wait_ready(), but I'm
still playing with it.
--
Andrew E. Mileski
prev parent reply other threads:[~2008-07-14 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 19:22 [PATCH] nand_wait_ready() timeout scaling Andrew E. Mileski
2008-04-30 19:46 ` Andrew E. Mileski
2008-04-30 20:19 ` Trent Piepho
2008-04-30 20:55 ` Andrew E. Mileski
2008-07-14 20:32 ` Andrew E. Mileski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487BB7D9.4070505@isoar.ca \
--to=andrewm@isoar.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox