From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpauth02.csee.onr.siteprotect.com ([64.26.60.136]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KUpVK-0000UY-An for linux-mtd@lists.infradead.org; Sun, 17 Aug 2008 21:09:38 +0000 Message-ID: <48A8937D.1010007@boundarydevices.com> Date: Sun, 17 Aug 2008 14:09:17 -0700 From: Troy Kisky MIME-Version: 1.0 To: frans Subject: Re: [RESUBMIT] [PATCH] [MTD] NAND nand_ecc.c: rewrite for improved performance References: <1218472202.2977.12.camel@pmac.infradead.org> <1218535872.2977.133.camel@pmac.infradead.org> <48A48330.70105@boundarydevices.com> <1218789997.3184.64.camel@pmac.infradead.org> <1218793271.3184.77.camel@pmac.infradead.org> <1218795140.3184.84.camel@pmac.infradead.org> <48A5D154.2000409@boundarydevices.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , frans wrote: > > On Fri, 15 Aug 2008, Troy Kisky wrote: >> You might also test it on a big endian system to be safe. >> >> Troy >> > Good remark! > I should have mentioned this more explicitly. As mentioned before I did test > on Linksys NSLU2. This is an ARM and standard Linksys software (as well as > the std unslung one from nslu2-linux.org) is big endian (and yes, that > is the part I did not mention). > So, you have tried reading a file system that was created before your patch was applied on a big endian system? Sorry to be a pest, but I didn't see any endian-ness test in your patch. But I will admit that my eyes aren't very good. I'm especially bad at spotting the jelly in the fridge. :^) Troy