From: Troy Kisky <troy.kisky@boundarydevices.com>
To: frans <fransmeulenbroeks@gmail.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RESUBMIT] [PATCH] [MTD] NAND nand_ecc.c: rewrite for improved performance
Date: Sun, 17 Aug 2008 16:30:14 -0700 [thread overview]
Message-ID: <48A8B486.5070900@boundarydevices.com> (raw)
In-Reply-To: <alpine.DEB.0.99.0808152300300.9220@frans-desktop>
> + if (nr_bits == 11) { /* correctable error */
This is a necessary, but NOT sufficient condition to
determine that it is a 1 bit error.
Big MAYBE below
This is probably why you passed the big endian test.
It was seeing every read as a single bit error
and silently correcting. Adding a debug print
when correcting or failing to correct would be
useful.
Troy
next prev parent reply other threads:[~2008-08-17 23:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 8:35 [RESUBMIT] [PATCH] [MTD] NAND nand_ecc.c: rewrite for improved performance frans
2008-08-11 11:35 ` Frans Meulenbroeks
2008-08-11 16:30 ` David Woodhouse
[not found] ` <ac9c93b10808120153m7435424ci3e49a70d3599cc06@mail.gmail.com>
[not found] ` <1218535872.2977.133.camel@pmac.infradead.org>
2008-08-14 18:07 ` frans
2008-08-14 19:10 ` Troy Kisky
2008-08-15 8:41 ` Frans Meulenbroeks
2008-08-15 8:46 ` David Woodhouse
2008-08-15 9:23 ` Frans Meulenbroeks
2008-08-15 9:41 ` David Woodhouse
2008-08-15 10:04 ` Frans Meulenbroeks
2008-08-15 10:12 ` David Woodhouse
2008-08-15 18:56 ` Troy Kisky
2008-08-15 21:14 ` frans
2008-08-16 10:04 ` David Woodhouse
2008-08-17 21:09 ` Troy Kisky
2008-08-18 6:33 ` Frans Meulenbroeks
2008-08-18 17:20 ` Troy Kisky
2008-08-18 21:09 ` Frans Meulenbroeks
2008-08-18 21:29 ` Troy Kisky
2008-08-18 21:31 ` David Woodhouse
2008-08-18 22:14 ` Troy Kisky
2008-08-18 22:10 ` Troy Kisky
2008-08-19 6:00 ` Frans Meulenbroeks
2008-08-17 23:30 ` Troy Kisky [this message]
2008-08-18 6:40 ` Frans Meulenbroeks
2008-08-18 17:08 ` Troy Kisky
-- strict thread matches above, loose matches on Subject: below --
2008-07-29 17:58 Frans Meulenbroeks
2008-07-29 20:04 ` Ricard Wanderlof
2008-07-30 6:17 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A8B486.5070900@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=dwmw2@infradead.org \
--cc=fransmeulenbroeks@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox