Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function

Lennert Buytenhek
2008-09-13T10:47:01Z

On Fri, Sep 12, 2008 at 11:33:08PM -0700, Zev Weiss wrote:

> Adding a dummy release function to the physmap device so as to silence a log
> warning on initialization.
>
> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
> ---
> drivers/mtd/maps/physmap.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 49e2039..73a8d3c 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {
> .flags = IORESOURCE_MEM,
> };
>
> +static void physmap_dummy_release(struct device *dev)
> +{
> +}
> +
> static struct platform_device physmap_flash = {
> .name = "physmap-flash",
> .id = 0,
> .dev = {
> .platform_data = &physmap_flash_data,
> + .release = &physmap_dummy_release,
> },
> .num_resources = 1,
> .resource = &physmap_flash_resource,

Isn't that just papering over the issue?