Re: [PATCH] [MTD] [NAND] GPIO NAND flash driver

Russell King - ARM Linux
2008-10-12T19:15:07Z

On Sun, Oct 12, 2008 at 03:04:06PM -0400, Mike Frysinger wrote:
> On Sun, Oct 12, 2008 at 06:13, Russell King - ARM Linux wrote:
> > It doesn't. The fact that the GPIO state is preserved when free'd on
> > PXA is just that it takes _more_ code to do anything else.
>
> so which is it ? GPIO state *should* be preserved, or PXA does it
> simply due to code frugality ?

May I remind you that _you_ are the one with the system which doesn't
preserve GPIO state.

> if the API behavior is strictly documented, your complaint here is
> pretty moot.

My complaint? I don't have a complaint. You are the one with the
complaint with the driver that's being discussed. You're the one
who's moaning about it setting state before calling gpio_free.

I see no point in continuing this discussion; your arguments are
just plain silly. I've explained _why_ we're doing it.

Our GPIO hardware behaves differently from yours. Our gpio_free()
is side-effect free. Get over it.