Re: [PATCH] [MTD] [NAND] GPIO NAND flash driver

David Woodhouse
2008-10-13T13:59:04Z

On Sun, 2008-10-12 at 10:02 +0200, Mike Rapoport wrote:
> Mike Frysinger wrote:
> >> The problem is that a write to GPIO may pass a write to the static
> >> memory regions, or vice versa. So, what we do is we insert a read
> >> with a dependency in the execution to ensure that we stall the
> >> pipeline until that read - and therefore the preceding write has
> >> completed.
> >
> > so the function comment should read something like "make sure the gpio
> > state has actually changed before returning to the higher nand layers"
> >
>
> The patch with (hopefully) clearer gpio_nand_dosync() comments.

Please can I have it in a form I can apply, with changelog and
signed-off-by, and without those silly 'u16' types in it. The C language
has perfectly good types for specifying unsigned 16-bit integers; use
them.

Thanks.

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation