Re: [REFERENCE PATCH][OneNAND] S3C64XX support

[Adrian Hunter <ext-adrian.hunter@nokia.com>]

Kyungmin Park wrote:
> On Tue, Oct 21, 2008 at 12:07 AM, Adrian Hunter
> <ext-adrian.hunter@nokia.com> wrote:
>> Kyungmin Park wrote:
>>> It's OneNAND support on New Samsung Mobile CPU S3C64XX series Now it's
>>> only tested with s3c6410 with UBI & UBIFS.
>>> If you want to use it on s3c6400, you should change some values.
>>>
>>> There's some ugly hack for support s3c64xx. It will be handled more fancy
>>> later.
>>>
>>> Any comments are welcome
>> Why not just make it a separate driver and skip using onenand_base etc?
>>
> 
> DId you see the s3c64xx OneNAND controller?. It has its own OneNAND
> controller and don't use the OneNAND memory access method as OMAP.
> 
> Yes it's possible to make an own OneNAND driver for s3c64xx, but maybe
> a half of codes are redundant except the access method  so I want to
> use default onenand_base and just redefine the OneNAND function for
> s3c64xx.


I glanced at the code.  It did not look like there was much code from
onenand_base that was needed, so wouldn't it be cleaner to just copy
those bits?