Re: [PATCH v3 3/6] mtd: dataflash: Replace pr_debug, printk with dev_* functions

Andrey Smirnov
2017-04-19T15:52:28Z

On Wed, Apr 19, 2017 at 8:33 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On 04/19/2017 05:23 PM, Andrey Smirnov wrote:
>> Lion's share of calls to pr_debug in this driver follow the pattern of
>> pr_debug("%s <message>", dev_name(<dev>), <arguments>), which should
>> be semantically identical to dev_dbg(<dev>, "<message>", <arguments>),
>> so replace such occurencies to simplify the code.
>>
>> Convert the small minority of pr_debug that do not follow pattern from
>> above to use dev_dbg as well, for the sake of consistency.
>>
>> Convert similar patter of printk(KERN_ERR, "%s: ...", dev_name(...),
>> ...) to use dev_err instead.
>>
>> No functional change intended.
>>
>> Cc: cphealy@gmail.com
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Cc: Marek Vasut <marek.vasut@gmail.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Cc: linux-kernel@vger.kernel.or
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>
> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
>
> btw where is 1/6 and 2/6 ?

Sorry, looks like git send-mail didn't pick up Acked-by tag to be
added to CC list. They are here:

https://marc.info/?l=linux-kernel&m=149261547916625
https://marc.info/?l=linux-kernel&m=149261543416614

>
> --
> Best regards,
> Marek Vasut