public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Cal Page <pagcal@runbox.com>
To: ubifs <linux-mtd@lists.infradead.org>
Subject: ubifs: another scheduling while atomic back trace
Date: Thu, 18 Dec 2008 08:34:54 -0500	[thread overview]
Message-ID: <494A517E.2000405@runbox.com> (raw)

I tracked it down to fs/ubifs/journal.c in make_reservation()?

the code is:
    again:
       down_read()
       err = reserve_space()
       if ( !err) return 0
       up_read()

shouldn't we to the up as part of the if? ie

    if ( !err ) { up_read(); return 0; };

Also, I notice fs/fs-writeback.c in writeback_inodes does a 
down_read_trylock. Won't this interfear with the down_read above?

Cal Page

             reply	other threads:[~2008-12-18 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 13:34 Cal Page [this message]
2008-12-18 13:53 ` ubifs: another scheduling while atomic back trace Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2008-12-17 17:10 Cal Page

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494A517E.2000405@runbox.com \
    --to=pagcal@runbox.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox