From: Wolfgang Grandegger <wg@grandegger.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH] CFI: remove major/minor version check for command set 0x0002
Date: Thu, 08 Jan 2009 17:59:56 +0100 [thread overview]
Message-ID: <4966310C.1010103@grandegger.com> (raw)
In-Reply-To: <1231433317.28362.77.camel@macbook.infradead.org>
David Woodhouse wrote:
> On Thu, 2009-01-08 at 11:47 -0500, Nicolas Pitre wrote:
>>> The NOR Flash memory K8P2815UQB from Samsung uses the major version
>>> number '0', which seems to be unusual but not illegal, IIUC. This
>>> patch removes the major-minor version check to get this Flash memory
>>> supported as well.
>> Instead of removing the test entirely, I'd suggest you augment it with
>> the manufacturer ID (cfi->mfr and cfi->id). Or better yet, just use
>> that information to fix up the version number to something sensible.
>
> Couldn't you use a quirk to do the latter?
The major/minor version number is not used anywhere else and therefore a
quirk seems to be overkill too me. But we may want to keep the message:
Unknown Amd/Fujitsu Extended Query version 0.0.
Wolfgang.
next prev parent reply other threads:[~2009-01-08 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 16:07 [PATCH] CFI: remove major/minor version check for command set 0x0002 Wolfgang Grandegger
2009-01-08 16:47 ` Nicolas Pitre
2009-01-08 16:48 ` David Woodhouse
2009-01-08 16:59 ` Wolfgang Grandegger [this message]
2009-01-08 17:42 ` Nicolas Pitre
2009-01-08 18:21 ` Wolfgang Grandegger
2009-01-08 18:33 ` Nicolas Pitre
2009-01-09 13:04 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966310C.1010103@grandegger.com \
--to=wg@grandegger.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox