From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from terminus.zytor.com ([198.137.202.10]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1LOJk5-0004Ni-BJ for linux-mtd@lists.infradead.org; Sat, 17 Jan 2009 22:34:15 +0000 Message-ID: <49725B1E.604@kernel.org> Date: Sat, 17 Jan 2009 14:26:38 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 To: Sam Ravnborg Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings References: <1232223441.3966.22.camel@localhost.localdomain> <1232228261.27094.0.camel@macbook.infradead.org> <20090117221932.GA4956@uranus.ravnborg.org> In-Reply-To: <20090117221932.GA4956@uranus.ravnborg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: urs.thuermann@volkswagen.de, neilb@suse.de, greg@kroah.com, bfields@fieldses.org, linux-mtd@lists.infradead.org, dbrownell@users.sourceforge.net, x86 maintainers , tiwai@suse.de, netfilter-devel@vger.kernel.org, Ingo Molnar , linux-media@vger.kernel.org, mchehab@infradead.org, linux-raid@vger.kernel.org, netfilter@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, LKML , Jaswinder Singh Rajput , oliver.hartkopp@volkswagen.de, spi-devel-general@lists.sourceforge.net, Andrew Morton , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sam Ravnborg wrote: >>> >> That patch looks wrong, and unnecessary. It was fine before. > Nope - include/linux/dvb/audio.h failed to include linux/types.h > despite the fact that is uses __u32 etc. > > But why the _kernel_ should include a userspace header is > much more questionable. > is one of a handful of headers provided by gcc itself. -hpa