From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: dedekind@infradead.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] ubiformat: make it work on mtd parts > 2GiB
Date: Wed, 11 Feb 2009 09:56:02 +0100 [thread overview]
Message-ID: <499292A2.9070708@linutronix.de> (raw)
In-Reply-To: <1234337417.17790.123.camel@localhost.localdomain>
Artem Bityutskiy wrote:
> On Tue, 2009-02-10 at 11:33 +0100, Sebastian Andrzej Siewior wrote:
>> diff --git a/ubi-utils/new-utils/src/libmtd.c b/ubi-utils/new-utils/src/libmtd.c
>> index aab4b0e..69705dd 100644
>> --- a/ubi-utils/new-utils/src/libmtd.c
>> +++ b/ubi-utils/new-utils/src/libmtd.c
>> @@ -189,7 +189,7 @@ int mtd_is_bad(const struct mtd_info *mtd, int eb)
>> if (!mtd->allows_bb)
>> return 0;
>>
>> - seek = eb * mtd->eb_size;
>> + seek = (unsigned int)eb * mtd->eb_size;
>
> I believe this should be:
>
> seek = (off_t)eb * mtd->eb_size;
>
> instead.
Yes, indeed.
>
Sebastian
next prev parent reply other threads:[~2009-02-11 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 9:56 [RFC / PATCH] ubiformat: make it work on mtd parts > 2GiB Sebastian Andrzej Siewior
2009-02-10 10:06 ` Artem Bityutskiy
2009-02-10 10:17 ` Sebastian Andrzej Siewior
2009-02-10 10:27 ` Artem Bityutskiy
2009-02-10 10:49 ` Sebastian Andrzej Siewior
2009-02-11 7:30 ` Artem Bityutskiy
2009-02-11 9:05 ` [PATCH] get rid of "compare between signed and unsigned" warnings Sebastian Andrzej Siewior
2009-02-10 10:33 ` [PATCH v2] ubiformat: make it work on mtd parts > 2GiB Sebastian Andrzej Siewior
2009-02-11 7:30 ` Artem Bityutskiy
2009-02-11 8:56 ` Sebastian Andrzej Siewior [this message]
2009-02-11 9:04 ` [PATCH v3] " Sebastian Andrzej Siewior
2009-02-11 10:23 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499292A2.9070708@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox