Re: [PATCH] MTD: nandsim should delete its partitions on module unload

Adrian Hunter
2009-04-03T06:57:21Z

Kevin Cernekee wrote:
> Signed-off-by: Kevin Cernekee <kpc.mtd@gmail.com>
> ---
> drivers/mtd/nand/nandsim.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index cd0711b..f4fda9b 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2349,6 +2349,7 @@ static void __exit ns_cleanup_module(void)
> struct nandsim *ns = (struct nandsim *)(((struct nand_chip
> *)nsmtd->priv)->priv);
> int i;
>
> + del_mtd_partitions(nsmtd);
> free_nandsim(ns); /* Free nandsim private resources */
> nand_release(nsmtd); /* Unregister driver */
> for (i = 0;i < ARRAY_SIZE(ns->partitions); ++i)

Doesn't nand_release() already do that?