From: Troy Kisky <troy.kisky@boundarydevices.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/5] mtd: nand: cafe_nand: use default ecc layout
Date: Thu, 14 May 2009 14:18:38 -0700 [thread overview]
Message-ID: <4A0C8AAE.1040601@boundarydevices.com> (raw)
In-Reply-To: <200905132218.28687.david-b@pacbell.net>
David Brownell wrote:
> On Wednesday 13 May 2009, Troy Kisky wrote:
>> The bad block marker is at 14, but oobfree also
>> starts at 14. This doesn't make sense to me,
>
> On-chip bad-block tables stick the "Bbt0" (etc)
> tags into the OOB data area, and don't need to
> share that area with anything else. It's OK.
>
>
>> so I don't know if this patch is good or not.
>
> Isn't this one of the drivers using NAND_ECC_HW_SYNDROME?
> So that the ecclayout is fully defined by prepad==0?
>
> This is a case where you *could* safely generate the
> current ecclayout structs using simple rules.
>
>
Actually, cafe_nand overrides most everything and doesn't use
prepad or postpad or ecc.layout. But I think it still relies
on ecc.layout.oobfree to setup chip->oob_poi. So, I'm no closer
to understanding why oobfree and bad block marker start at 14.
Troy
prev parent reply other threads:[~2009-05-14 21:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1242270008-1552-1-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 4:42 ` [PATCH 1/5] mtd: nand: move layout structure into nand_ecc_ctrl David Brownell
2009-05-14 17:53 ` Troy Kisky
2009-05-14 18:08 ` David Brownell
[not found] ` <1242270008-1552-2-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:10 ` [PATCH 2/5] mtd: nand: Calculate better default ecc layout David Brownell
2009-05-14 17:59 ` Troy Kisky
[not found] ` <1242270008-1552-3-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:12 ` [PATCH 3/5] mtd: nand: atmel: use " David Brownell
2009-05-14 8:23 ` Haavard Skinnemoen
2009-05-14 18:08 ` Troy Kisky
2009-05-15 7:26 ` Richard Genoud
2009-05-15 19:57 ` Richard Genoud
2009-05-15 22:15 ` Troy Kisky
2009-05-15 22:38 ` Richard Genoud
2009-05-15 23:04 ` Troy Kisky
2009-05-14 18:04 ` Troy Kisky
2009-05-20 15:19 ` Nicolas Ferre
2009-05-20 18:28 ` Troy Kisky
[not found] ` <1242270008-1552-4-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:18 ` [PATCH 4/5] mtd: nand: cafe_nand: " David Brownell
2009-05-14 21:18 ` Troy Kisky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C8AAE.1040601@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=david-b@pacbell.net \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).