From: Jehan Bing <jehan@orb.com>
To: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD-UTILS] Incorrect loop condition
Date: Fri, 05 Jun 2009 18:45:53 -0700 [thread overview]
Message-ID: <4A29CA51.1070906@orb.com> (raw)
In-Reply-To: <1244204148.5847.54.camel@localhost.localdomain>
Small patch to fix an obvious typo.
If the file contains only a few bytes in the last page and the --oob option is selected, the loop may exit early (readlen < meminfo.oobsize).
Most of the time it will still work though because the code tries to read the whole OOB in one chunk.
Signed-off-by: Jehan Bing <jehan@orb.com>
--- a/nandwrite.c 2009-06-01 18:03:55.000000000 -0700
+++ b/nandwrite.c 2009-06-05 18:32:56.000000000 -0700
@@ -531,7 +531,7 @@ int main(int argc, char * const argv[])
if (writeoob) {
int tinycnt = 0;
- while(tinycnt < readlen) {
+ while(tinycnt < meminfo.oobsize) {
cnt = read(ifd, oobreadbuf + tinycnt, meminfo.oobsize - tinycnt);
if (cnt == 0) { // EOF
break;
next prev parent reply other threads:[~2009-06-06 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 1:18 [PATCH] [MTD-UTILS] Incorrect loop condition Nahor
2009-06-05 12:15 ` Artem Bityutskiy
2009-06-06 1:45 ` Jehan Bing [this message]
2009-06-08 6:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A29CA51.1070906@orb.com \
--to=jehan@orb.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox