[PATH] [MTD-UTILS] Return error if failure when reading from standard input

[PATH] [MTD-UTILS] Return error if failure when reading from standard input

[Nahor]

The test to return SUCCESS or FAILURE at the end of nandwrite is done 
only when reading from a file. When reading from the standard input, 
nandwrite always returns success except for some cases at the begining.

This patches aims at fixing that by returning an error when jumping to 
the closeall label.

Regards,
	Nahor


--- a/nandwrite.c       2009-06-01 18:03:55.000000000 -0700
+++ b/nandwrite.c       2009-06-03 17:25:19.000000000 -0700
@@ -261,6 +261,7 @@
         int oobinfochanged = 0;
         struct nand_oobinfo old_oobinfo;
         int readcnt = 0;
+       bool failed = true;

         process_options(argc, argv);

@@ -623,6 +624,8 @@
                 mtdoffset += meminfo.writesize;
         }

+       failed = false;
+
  closeall:
         close(ifd);

@@ -637,7 +640,7 @@

         close(fd);

-       if ((ifd != STDIN_FILENO) && (imglen > 0)) {
+       if (failed || ((ifd != STDIN_FILENO) && (imglen > 0))) {
                 perror ("Data was only partially written due to error\n");
                 exit (EXIT_FAILURE);
         }

Re: [PATH] [MTD-UTILS] Return error if failure when reading from standard input

[Artem Bityutskiy]

On Thu, 2009-06-04 at 10:23 -0700, Nahor wrote:
> The test to return SUCCESS or FAILURE at the end of nandwrite is done 
> only when reading from a file. When reading from the standard input, 
> nandwrite always returns success except for some cases at the begining.
> 
> This patches aims at fixing that by returning an error when jumping to 
> the closeall label.

Looks ok to me. Please, send an applicable patch.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

Re: [PATH] [MTD-UTILS] Return error if failure when reading from standard input

[Jehan Bing]

Fix nandwrite to return EXIT_FAILURE in case of error when using the
standard input instead of a file for input.


Signed-off-by: Jehan Bing <jehan@orb.com>

diff -up mtd-utils.loop/nandwrite.c mtd-utils.failed_patch/nandwrite.c
--- mtd-utils.loop/nandwrite.c	2009-06-05 18:32:56.000000000 -0700
+++ mtd-utils.failed_patch/nandwrite.c	2009-06-03 17:25:19.000000000 -0700
@@ -261,6 +261,7 @@ int main(int argc, char * const argv[])
 	int oobinfochanged = 0;
 	struct nand_oobinfo old_oobinfo;
 	int readcnt = 0;
+	bool failed = true;
 
 	process_options(argc, argv);
 
@@ -623,6 +624,8 @@ int main(int argc, char * const argv[])
 		mtdoffset += meminfo.writesize;
 	}
 
+	failed = false;
+
 closeall:
 	close(ifd);
 
@@ -637,7 +640,7 @@ restoreoob:
 
 	close(fd);
 
-	if ((ifd != STDIN_FILENO) && (imglen > 0)) {
+	if (failed || ((ifd != STDIN_FILENO) && (imglen > 0))) {
 		perror ("Data was only partially written due to error\n");
 		exit (EXIT_FAILURE);
 	}

Re: [PATH] [MTD-UTILS] Return error if failure when reading from standard input

[Artem Bityutskiy]

On Mon, 2009-06-08 at 09:32 -0700, Jehan Bing wrote:
> Fix nandwrite to return EXIT_FAILURE in case of error when using the
> standard input instead of a file for input.

Pushed, thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)