public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@nokia.com>
To: Mika Korhonen <mika.j.korhonen@gmail.com>
Cc: "kyungmin78@gmail.com" <kyungmin78@gmail.com>,
	linux-mtd Mailing List <linux-mtd@lists.infradead.org>,
	kyungmin.park@samsung.com
Subject: Re: RFC: [PATCH] MTD OneNAND: multiblock erase support
Date: Mon, 15 Jun 2009 13:11:56 +0300	[thread overview]
Message-ID: <4A361E6C.3000208@nokia.com> (raw)
In-Reply-To: <7948530906150003g365c8af3g9a9aaf8c8b985aa7@mail.gmail.com>

Mika Korhonen wrote:
> I wrote an initial support for OneNAND multiblock erase feature.  When
> done in maximum 64 eraseblock batches multiblock erase is up to 30x
> faster than block-by-block erase (not including erase verify, though).
> 
> However, I only had possibility to test this with an OMAP board, so I
> don't know if e.g. the default onenand_wait needs adjustment. Also for
> Flex-OneNAND the support goes off. Does Flex even have mb erase?
> 
> What do you think?

I expect all OneNAND support multiblock erase, so the config should
go away.  Kyungmin can probably comment on that.

Waiting for multiblock-erase, you should probably spin, not use the
interrupt line.  You should change the wait function in
onenand_base and omap2.c.

You should handle multiple multiblock erases.

You should check for bad blocks *before* doing command 0x95

Waiting for erase-verify, you should probably spin too.

  parent reply	other threads:[~2009-06-15 10:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15  7:03 RFC: [PATCH] MTD OneNAND: multiblock erase support Mika Korhonen
2009-06-15  7:29 ` Artem Bityutskiy
2009-06-15  7:54 ` Kyungmin Park
2009-06-15  8:20   ` Mika Korhonen
2009-06-15 10:11 ` Adrian Hunter [this message]
2009-06-15 11:02   ` Mika Korhonen
2009-06-18  7:01     ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A361E6C.3000208@nokia.com \
    --to=adrian.hunter@nokia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=kyungmin78@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mika.j.korhonen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox